You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/14 12:18:28 UTC

[GitHub] [apisix] shuaijinchao commented on issue #6604: chore: add semicolon check in `make lint`

shuaijinchao commented on issue #6604:
URL: https://github.com/apache/apisix/issues/6604#issuecomment-1066718526


   > > ### Issue description
   > > Check for `;` at the end of lua code and add the check to make lint.
   > 
   > @shuaijinchao I think more details can be supplemented so that it can be a good first issue.
   
   Yes, I am also investigating the details of the solution. There is currently a solution using grep command + regular expression, but this solution is not completely correct for current automatic filtering, so it cannot be applied to CI. I will sync to the issues when new solutions are available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org