You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by akilawickey <gi...@git.apache.org> on 2016/07/12 22:23:48 UTC
[GitHub] cordova-android pull request #315: CB-11078 fixed "Empty string for Backgrou...
GitHub user akilawickey opened a pull request:
https://github.com/apache/cordova-android/pull/315
CB-11078 fixed "Empty string for BackgroundColor preference crashes application" issue
A preference of
<preference name="BackgroundColor" value="" />
will cause an a cordova application to crash on startup with a NumberFormatException:
Fixed the isse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-android 5.2.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit fd1d3006c0f656091e6c45068f8653775eaa65d7
Author: Steve Gill <st...@gmail.com>
Date: 2016-06-29T19:39:42Z
CB-11444 Updated RELEASENOTES and Version for release 5.2.0
commit b32b8c89c6061ffe86161f4ab641cbab605a7aba
Author: Steve Gill <st...@gmail.com>
Date: 2016-06-29T19:51:05Z
Update JS snapshot to version 5.2.0 (via coho)
commit 97ce7dd417ea0e5baf0348d8a267ef3d723bb1a8
Author: Steve Gill <st...@gmail.com>
Date: 2016-06-29T19:51:05Z
Set VERSION to 5.2.0 (via coho)
commit 8416c4e5e9908aeee1445a107bb89decd69954b3
Author: Vivek Kiran <vi...@outlook.com>
Date: 2016-06-24T05:08:23Z
CB-11481: android-library is deprecated use com.android.library instead
commit 40d3cdc0d646364c2d118758049f73b78503c68f
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2016-07-06T12:12:36Z
CB-9489 Fixed "endless waiting for emulator" issue
commit 89a00c02a40cae162708fd20e93c958ecaa3dbf9
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-07-11T10:41:00Z
CB-11550 Updated and checked-in node_modules
commit 81b2bccd977b4237ad2ac10c5e89c9051969b311
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-07-11T10:41:30Z
CB-11550 Update JS snapshot to version 5.2.1 (via coho)
commit cbed234069080331084689bfff3354d3b26dbf32
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-07-11T10:41:31Z
CB-11550 Set VERSION to 5.2.1 (via coho)
commit 35dfdece12aa0791a081c33af75dbc3f8d4b0c76
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-07-11T10:43:38Z
CB-11550 Updated RELEASENOTES for release 5.2.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #315: CB-11078 "Empty string for BackgroundColo...
Posted by akilawickey <gi...@git.apache.org>.
Github user akilawickey closed the pull request at:
https://github.com/apache/cordova-android/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #315: CB-11078 "Empty string for BackgroundColor prefe...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/315
This pr was closed in favor of #316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #315: CB-11078 "Empty string for BackgroundColor prefe...
Posted by akilawickey <gi...@git.apache.org>.
Github user akilawickey commented on the issue:
https://github.com/apache/cordova-android/pull/315
Ok i'll fix it soon
On Wed, Jul 13, 2016 at 11:29 AM, Sergey Shakhnazarov <
notifications@github.com> wrote:
> Ensure you are creating a PR from the correct branch - it should be
> https://github.com/akilawickey/cordova-android -> master (and now it is
> coming from 5.2.x).
> Also please rename commit title from fixed CB-11078 Empty string for
> BackgroundColor preference crashes application to CB-11078 Empty string
> for BackgroundColor preference crashes application.
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-android/pull/315#issuecomment-232263909>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AKzUNI0NcU_P4kcIG8hwCUfHqa5qbh6fks5qVH7MgaJpZM4JK44s>
> .
>
--
*Thanks and Regards,*Akila Wickramarachchi
Undergraduate at University Of Peradeniya
<https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-headline>
Email : asak999@gmail.com
Linkedin : Akila Wickramarachchi
<https://www.linkedin.com/profile/view?id=AAMAABg_m_sBqt7aECwMPaTfYpf-olFytcSylC4&trk=hp-identity-name>
Blog : http://akilacollection.blogspot.com/
Github : https://github.com/akilawickey
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #315: CB-11078 fixed "Empty string for BackgroundColor...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-android/pull/315
Ensure you are creating a PR from the correct branch - it should be https://github.com/akilawickey/cordova-android -> master (and now it is coming from `5.2.x`).
Also please rename commit title from `fixed CB-11078 Empty string for BackgroundColor preference crashes application` to `CB-11078 Empty string for BackgroundColor preference crashes application`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org