You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/21 22:29:27 UTC
[GitHub] [druid] gianm commented on a change in pull request #9163: Improved
the readability and fixed few java warnings
gianm commented on a change in pull request #9163: Improved the readability and fixed few java warnings
URL: https://github.com/apache/druid/pull/9163#discussion_r382836818
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidConvention.java
##########
@@ -73,7 +73,7 @@ public RelTraitDef getTraitDef()
@Override
public boolean satisfies(RelTrait trait)
{
- return trait == this;
+ return trait.equals(this);
Review comment:
It's ok, IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org