You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/03/19 16:40:06 UTC

[GitHub] [curator] eolivelli commented on a change in pull request #334: [CURATOR-549] Support ZooKeeper 3.6.0 Persistent Recursive Watchers

eolivelli commented on a change in pull request #334: [CURATOR-549] Support ZooKeeper 3.6.0 Persistent Recursive Watchers
URL: https://github.com/apache/curator/pull/334#discussion_r395164268
 
 

 ##########
 File path: curator-x-async/src/main/java/org/apache/curator/x/async/details/AsyncCuratorFrameworkImpl.java
 ##########
 @@ -151,6 +153,13 @@ public AsyncRemoveWatchesBuilder removeWatches()
         return new AsyncRemoveWatchesBuilderImpl(client, filters);
     }
 
+    @Override
+    public AsyncWatchBuilder addWatch()
+    {
+        Preconditions.checkState(Compatibility.hasPersistentWatchers(), "addWatch() is not supported in the ZooKeeper library being used.");
 
 Review comment:
   I would throw UnsupportedOperationException

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services