You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/12/03 02:51:40 UTC

[GitHub] [iotdb] yanhongwangg opened a new pull request #2170: set max number of open files in start-node.sh

yanhongwangg opened a new pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] mychaow commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-742193932


   > Maybe we can ask the user like this:
   > 
   > ```
   > ./start-node.sh
   > Warning: System maximum open file number is too small, so IoTDB wishes to set it to 65535.[y/n]
   > ```
   
   Good idea.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-741528676


   This should better be put into env.sh instead of start-node.sh, so it may affect both stand-alone and cluter verison.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] liutaohua commented on a change in pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
liutaohua commented on a change in pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#discussion_r535889164



##########
File path: cluster/src/assembly/resources/sbin/start-node.sh
##########
@@ -18,6 +18,8 @@
 # under the License.
 #
 
+# Set max number of open files
+ulimit -n 65535

Review comment:
       some suggestions but not blocking:
   1. check whether the current user is `root`
   2. check if the current `ulimit` is greater than `65535`
   3. Add obvious hints that require manual modification




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 edited a comment on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
jt2594838 edited a comment on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-742184496


   Maybe we can ask the user like this:
   ```
   ./start-node.sh
   Warning: System maximum open file number is too small, so IoTDB wishes to set it to 65535.[y/n]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] liutaohua commented on a change in pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
liutaohua commented on a change in pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#discussion_r535883393



##########
File path: cluster/src/assembly/resources/sbin/start-node.sh
##########
@@ -18,6 +18,8 @@
 # under the License.
 #
 
+# Set max number of open files
+ulimit -n 65535

Review comment:
       What happens if the current user is not `root`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] yanhongwangg closed pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
yanhongwangg closed pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-741529843


   By the way, we did not add this because we thought that it was improper for an application to modify OS configuration without a proper request to the user.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
jt2594838 commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-742184496


   Maybe we can ask the user like this:
   ```
   ./start-node.sh
   Warning: System maximum open file number is too small, IoTDB wishes to set it to 65535.[y/n]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] mychaow commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
mychaow commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-741541229


   > By the way, we did not add this because we thought that it was improper for an application to modify OS configuration without a proper request to the user.
   
   I think we could do this for user. The user may not be familiar with the system, but if they have used it in production system, it's too late to modify the limit when system get error. 
   
   
   How do you think? @jixuan1989 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-737636407


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2170&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2170) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2170&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2170&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jt2594838 edited a comment on pull request #2170: set max number of open files in start-node.sh

Posted by GitBox <gi...@apache.org>.
jt2594838 edited a comment on pull request #2170:
URL: https://github.com/apache/iotdb/pull/2170#issuecomment-741528676


   This should better be put into env.sh instead of start-node.sh, so it may affect both stand-alone and cluster verison.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org