You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/10 22:18:50 UTC
[GitHub] [tvm] comaniac opened a new pull request #7087: [Relay] Deformable Conv2D layout conversion
comaniac opened a new pull request #7087:
URL: https://github.com/apache/tvm/pull/7087
This PR implements the required functions for deformable conv2D to perform layout conversion between NHWC and NCHW. Please also be aware of the following points in the review:
- I am not sure if simply returning `None` is ok for alter op and legalize functions.
- I suppose we don't need to consider QNN yet because we only have the FP32 computes in TOPI?
cc @anijain2305 @yzhliu @vinx13 @Laurawly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] giuseros commented on pull request #7087: [Relay][ConvertLayout] Support deformable conv2d
Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #7087:
URL: https://github.com/apache/tvm/pull/7087#issuecomment-745172376
Nice addition! I confirm that you can safely return `None` from `alter_op_layout` and `legalization`. As for the quantized support I agree we should not add it in this PR (although it should be as simple as adding a `qnn.legalization` step + qnn operator in Relay)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #7087: [Relay][ConvertLayout] Support deformable conv2d
Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7087:
URL: https://github.com/apache/tvm/pull/7087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #7087: [Relay][ConvertLayout] Support deformable conv2d
Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7087:
URL: https://github.com/apache/tvm/pull/7087#issuecomment-745629617
Thanks @yzhliu @giuseros!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org