You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 19:25:07 UTC
[GitHub] [arrow] wesm opened a new pull request, #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
wesm opened a new pull request, #13790:
URL: https://github.com/apache/arrow/pull/13790
This should remain correct until we hit major version 100 (or make changes that otherwise affect the metadata size)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13790:
URL: https://github.com/apache/arrow/pull/13790#issuecomment-1204475379
+1. The CI failure is unrealted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13790:
URL: https://github.com/apache/arrow/pull/13790#issuecomment-1204615411
Benchmark runs are scheduled for baseline = db6c099b1306e9b4d5b0b103fa2779d5cbdcf321 and contender = ee874d67ddd417e5c33aff1979df782c4dfa1dfb. ee874d67ddd417e5c33aff1979df782c4dfa1dfb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15146580fcb140aa9f92b436a3304283...e9a28d24e5b54d888129d436a1bf29f4/)
[Failed :arrow_down:0.78% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5dc1cdf54b9c4649bd83ac018df51665...dc9c17f62a6a4387a9dc217bf011cd93/)
[Finished :arrow_down:0.82% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5abec5c4436544028f52fe2e89114b83...6d37671adf174e8789675aaaa0ed644b/)
[Finished :arrow_down:0.07% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/eea99dfc6e3c4cba8f1fb825c19d481c...ed9feb48e85a4954b9cdc599bd019764/)
Buildkite builds:
[Failed] [`ee874d67` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1253)
[Finished] [`ee874d67` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1265)
[Finished] [`ee874d67` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1248)
[Finished] [`ee874d67` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1267)
[Failed] [`db6c099b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1252)
[Failed] [`db6c099b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1264)
[Finished] [`db6c099b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1247)
[Finished] [`db6c099b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1266)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13790:
URL: https://github.com/apache/arrow/pull/13790#issuecomment-1204382166
https://issues.apache.org/jira/browse/ARROW-17296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13790:
URL: https://github.com/apache/arrow/pull/13790#issuecomment-1204382190
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm merged pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
wesm merged PR #13790:
URL: https://github.com/apache/arrow/pull/13790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13790:
URL: https://github.com/apache/arrow/pull/13790#discussion_r937055585
##########
python/pyarrow/parquet/__init__.py:
##########
@@ -3419,7 +3419,7 @@ def read_metadata(where, memory_map=False, decryption_properties=None):
num_rows: 3
num_row_groups: 1
format_version: 2.6
- serialized_size: 561
+ serialized_size: 562
Review Comment:
Perhaps we should not care about the actual size in docstring examples.
```suggestion
serialized_size: ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13790: ARROW-17296: [Python] Update serialized metadata size in pyarrow.parquet.read_metadata doctest
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13790:
URL: https://github.com/apache/arrow/pull/13790#issuecomment-1204615566
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/5dc1cdf54b9c4649bd83ac018df51665...dc9c17f62a6a4387a9dc217bf011cd93/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org