[GitHub] [skywalking] wu-sheng commented on a change in pull request #6516: Add telemetry data about metrics in, metrics scratching and trace in metrics to zipkin receiver.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #6516:
URL: https://github.com/apache/skywalking/pull/6516#discussion_r589396288



##########
File path: oap-server/server-fetcher-plugin/prometheus-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/fetcher/prometheus/provider/PrometheusFetcherProvider.java
##########
@@ -62,8 +67,22 @@
 
     private ScheduledExecutorService ses;
 
+    private final HistogramMetrics histogram;
+
+    private final CounterMetrics errorCounter;
+
     public PrometheusFetcherProvider() {
         config = new PrometheusFetcherConfig();
+        MetricsCreator metricsCreator = getManager().find(TelemetryModule.NAME)
+                .provider()
+                .getService(MetricsCreator.class);
+        histogram = metricsCreator.createHistogramMetric(
+                "metrics_scratch_latency", "The process latency of metrics scratching",

Review comment:
       ```suggestion
                   "metrics_fetcher_latency", "The process latency of metrics scratching",
   ```
   `scratch` -> `fetcher`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org