[GitHub] [openwhisk] MichaelGoberling commented on issue #3392: Sequence marked "final" can override action parameters

["MichaelGoberling (via GitHub)" <gi...@apache.org>]

MichaelGoberling commented on issue #3392:
URL: https://github.com/apache/openwhisk/issues/3392#issuecomment-1503835821

   @rabbah @cjelger 
   
   Re-opening this discussion as I've recently run into a use case that would benefit from this feature being added. (Our desired use case is basically to create a bindable validator action with an allow-list that will be used at the start of sequences, the allow-list should be immutable)
   
   I think applying the final annotation to all actions would be useful. In my experience, it's a common pattern to create a set of non-web actions and then expose them via a web sequence. 
   
   As for the `final` annotation not applying to sequences - A possible path forward would be to make the final annotation check a little more intelligent by inspecting each package and each action's parameter list to see if a passed parameter is present. If the `final` annotation is included for the sequence, we check everything. If the `final` annotation is not included, then we respect the `final` annotation on each package and action, if present.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org