You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/17 13:27:58 UTC
[GitHub] [pulsar] nicoloboschi commented on a change in pull request #13376: Make Docker images non-root, by default, and OpenShift compliant
nicoloboschi commented on a change in pull request #13376:
URL: https://github.com/apache/pulsar/pull/13376#discussion_r771392645
##########
File path: conf/bkenv.sh
##########
@@ -18,6 +18,8 @@
# under the License.
#
+# NOTE: this script is intentionally not executable. It is only meant to be sourced for environment variables.
Review comment:
what about removing the execution permission ? in this way you can run `source conf/bkenv.sh` but you can't run it using `./conf/bkenv.sh`
btw not sure it's worth to do thatÂ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org