You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/21 00:10:44 UTC

[GitHub] cjolivier01 commented on a change in pull request #10108: [MXNET-99] Upgrade to cuda 9.1 cudnn 7

cjolivier01 commented on a change in pull request #10108: [MXNET-99] Upgrade to cuda 9.1 cudnn 7
URL: https://github.com/apache/incubator-mxnet/pull/10108#discussion_r175959825
 
 

 ##########
 File path: python/mxnet/model.py
 ##########
 @@ -848,7 +848,7 @@ def fit(self, X, y=None, eval_data=None, eval_metric='acc',
         # init optmizer
         if isinstance(self.optimizer, str):
             batch_size = data.batch_size
-            if kvstore and 'dist' in kvstore.type and not '_async' in kvstore.type:
+            if kvstore and 'dist' in kvstore.type and '_async' not in kvstore.type:
                 batch_size *= kvstore.num_workers
 
 Review comment:
   need unit test for both cases (in and not in)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services