You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/25 14:46:23 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6923: net: remove pvconn reference from all devif callback
xiaoxiang781216 commented on code in PR #6923:
URL: https://github.com/apache/incubator-nuttx/pull/6923#discussion_r955057532
##########
net/tcp/tcp_connect.c:
##########
@@ -149,7 +148,6 @@ static void psock_teardown_callbacks(FAR struct tcp_connect_s *pstate,
*
* Input Parameters:
* dev The structure of the network driver that reported the event
- * pvconn The connection structure associated with the socket
Review Comment:
pvconn->pvpriv
##########
net/icmp/icmp_recvmsg.c:
##########
@@ -93,8 +93,7 @@ struct icmp_recvfrom_s
****************************************************************************/
static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
remove line 83
##########
net/tcp/tcp_sendfile.c:
##########
@@ -122,17 +122,8 @@ struct sendfile_s
****************************************************************************/
static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn, FAR void *pvpriv,
Review Comment:
update line 113
##########
net/tcp/tcp_recvfrom.c:
##########
@@ -363,7 +363,6 @@ static inline void tcp_sender(FAR struct net_driver_s *dev,
*
* Input Parameters:
* dev The structure of the network driver that generated the event.
- * pvconn The connection structure associated with the socket
Review Comment:
pvconn->pvpriv
##########
net/udp/udp_recvfrom.c:
##########
@@ -411,7 +411,6 @@ static void udp_terminate(FAR struct udp_recvfrom_s *pstate, int result)
*
* Input Parameters:
* dev The structure of the network driver that generated the event.
- * pvconn The connection structure associated with the socket
Review Comment:
pvconn->pvpriv
##########
net/icmpv6/icmpv6_netpoll.c:
##########
@@ -61,7 +61,6 @@
****************************************************************************/
static uint16_t icmpv6_poll_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
update line 52
##########
net/tcp/tcp_send_buffered.c:
##########
@@ -311,17 +311,8 @@ static inline void send_ipselect(FAR struct net_driver_s *dev,
****************************************************************************/
static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn, FAR void *pvpriv,
Review Comment:
update line 302
##########
net/sixlowpan/sixlowpan_send.c:
##########
@@ -98,7 +98,6 @@ struct sixlowpan_send_s
****************************************************************************/
static uint16_t send_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
update line 89
##########
net/tcp/tcp_send_unbuffered.c:
##########
@@ -169,17 +169,8 @@ static inline void tcpsend_ipselect(FAR struct net_driver_s *dev,
****************************************************************************/
static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
update line 100
##########
net/icmp/icmp_netpoll.c:
##########
@@ -61,7 +61,6 @@
****************************************************************************/
static uint16_t icmp_poll_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
update line 52
##########
net/icmpv6/icmpv6_recvmsg.c:
##########
@@ -96,8 +96,7 @@ struct icmpv6_recvfrom_s
****************************************************************************/
static uint16_t recvfrom_eventhandler(FAR struct net_driver_s *dev,
- FAR void *pvconn,
Review Comment:
remove line 86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org