You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/10/04 15:20:27 UTC

[GitHub] [kafka] officialpatterson opened a new pull request #11379: kafka-12994: Migrated SlidingWindowsTest to new API

officialpatterson opened a new pull request #11379:
URL: https://github.com/apache/kafka/pull/11379


   As raised in KAFKA-12994, All tests that use the old API should be either eliminated or migrated to the new API in order to remove the @SuppressWarnings("deprecation") annotations.
   
   This PR will migrate the SlidingWindowsTest to the new API.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman merged pull request #11379: kafka-12994: Migrated SlidingWindowsTest to new API

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11379:
URL: https://github.com/apache/kafka/pull/11379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] officialpatterson commented on pull request #11379: KAFKA-12994: Migrated SlidingWindowsTest to new API

Posted by GitBox <gi...@apache.org>.
officialpatterson commented on pull request #11379:
URL: https://github.com/apache/kafka/pull/11379#issuecomment-949084918


   > LGTM -- just one unrelated flaky test failure in `kafka.server.DynamicBrokerConfigTest.testPasswordConfigEncoderSecretChange()`
   
   Do we track flaky tests in Jira to be worked on?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #11379: KAFKA-12994: Migrated SlidingWindowsTest to new API

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11379:
URL: https://github.com/apache/kafka/pull/11379#issuecomment-949085661


   Yep -- see https://issues.apache.org/jira/browse/KAFKA-8197


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org