[GitHub] [doris] xxiao2018 commented on a diff in pull request #18342: [Refactor](multi catalog)Split ExternalFileScanNode into FileQueryScanNode and FileLoadScanNode.

["xxiao2018 (via GitHub)" <gi...@apache.org>]

xxiao2018 commented on code in PR #18342:
URL: https://github.com/apache/doris/pull/18342#discussion_r1161665138


##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalScanNode.java:
##########
@@ -21,9 +21,12 @@
 import org.apache.doris.planner.PlanNodeId;
 import org.apache.doris.planner.ScanNode;
 import org.apache.doris.statistics.StatisticalType;
-import org.apache.doris.thrift.TPlanNode;
 import org.apache.doris.thrift.TScanRangeLocations;
 
+import com.google.common.collect.Lists;

Review Comment:
   The import order is wrong



##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/ExternalScanNode.java:
##########
@@ -33,10 +36,20 @@
  * For example:
  * hive, iceberg, hudi, es, odbc
  */
-public class ExternalScanNode extends ScanNode {
+public abstract class ExternalScanNode extends ScanNode {
+    private static final Logger LOG = LogManager.getLogger(ExternalScanNode.class);
 
     // set to false means this scan node does not need to check column priv.
-    private boolean needCheckColumnPriv;
+    protected boolean needCheckColumnPriv;
+
+    // For explain
+    protected long inputSplitsNum = 0;

Review Comment:
   I think this 4 fields should be in `FileScanNode`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org