Re: Review Request 60389: Extract Log Search part from stack advisor to a separate service advisor

[Alejandro Fernandez <af...@hortonworks.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60389/#review179704
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py
Lines 114 (patched)
<https://reviews.apache.org/r/60389/#comment254539>

    Add documentation for each one of the recommendations here.


- Alejandro Fernandez


On June 30, 2017, 10:34 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60389/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 10:34 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Oliver Szabo, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21333
>     https://issues.apache.org/jira/browse/AMBARI-21333
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Extract Log Search service advisor from the stack advisor.
> Also created an empty Ambari Infra service advisor.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 726514b 
>   ambari-server/src/test/python/common-services/LOGSEARCH/test_service_advisor.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py c28ee2a 
> 
> 
> Diff: https://reviews.apache.org/r/60389/diff/3/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>