You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flume.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/11/30 13:30:00 UTC

[jira] [Commented] (FLUME-2957) Remove Guava from our public API

    [ https://issues.apache.org/jira/browse/FLUME-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704737#comment-16704737 ] 

ASF subversion and git services commented on FLUME-2957:
--------------------------------------------------------

Commit 46ea007df718b06813f6cee29e9dd06e26abaf6f in flume's branch refs/heads/flume-1.9 from [~fszabo]
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=46ea007 ]

FLUME-3295 Revert "FLUME-2957. Remove Guava from our public API"

This reverts commit 7f85df9e473ee675d461d5b76650694c5a6c0088.

This closes #252

Reviewers: Denes Arvay

(Ferenc Szabo via Ferenc Szabo)


> Remove Guava from our public API
> --------------------------------
>
>                 Key: FLUME-2957
>                 URL: https://issues.apache.org/jira/browse/FLUME-2957
>             Project: Flume
>          Issue Type: Task
>    Affects Versions: 1.8.0
>            Reporter: Lior Zeno
>            Assignee: Denes Arvay
>            Priority: Major
>              Labels: breaking_change
>             Fix For: 2.0.0
>
>
> Context.getParameters (flume-ng-configuration module) returns com.google.common.collect.ImmutableMap (Guava). We should clean our API and return either a native java interface or Flume's.
> In addition to the current state being a bad practice, this also means that we are unable to shade Guava in Flume.
> Note: Since this breaks our public API, I'll reschedule this issue to 2.0 once we have this version managed in jira.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@flume.apache.org
For additional commands, e-mail: issues-help@flume.apache.org