You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:06:27 UTC
[GitHub] [yunikorn-core] wusamzong opened a new pull request, #475: [YUNIKORN-1451] required node preemptor should use IsPreempted field
wusamzong opened a new pull request, #475:
URL: https://github.com/apache/yunikorn-core/pull/475
### What is this PR for?
I add a conditional statements to check if the allocations have preempted
### What type of PR is it?
* [x] - Bug Fix
### What is the Jira issue?
* Open an issue on Jira [https://issues.apache.org/jira/browse/YUNIKORN-1451](https://issues.apache.org/jira/browse/YUNIKORN-1451)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #475: [YUNIKORN-1451] required node preemptor should use IsPreempted field
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #475: [YUNIKORN-1451] required node preemptor should use IsPreempted field
URL: https://github.com/apache/yunikorn-core/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #475: [YUNIKORN-1451] required node preemptor should use IsPreempted field
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #475:
URL: https://github.com/apache/yunikorn-core/pull/475#issuecomment-1347917272
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#475](https://codecov.io/gh/apache/yunikorn-core/pull/475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7083228) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/234c8b12fba74e71a4010cd455e80f6e11ec8ad1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (234c8b1) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 72.51% 72.53% +0.02%
==========================================
Files 67 67
Lines 10110 10112 +2
==========================================
+ Hits 7331 7335 +4
+ Misses 2533 2530 -3
- Partials 246 247 +1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/required\_node\_preemptor.go](https://codecov.io/gh/apache/yunikorn-core/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3JlcXVpcmVkX25vZGVfcHJlZW1wdG9yLmdv) | `96.59% <0.00%> (-2.25%)` | :arrow_down: |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/yunikorn-core/pull/475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `87.50% <0.00%> (+2.08%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org