You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/01/05 15:22:55 UTC

[GitHub] flink pull request #3067: [FLINK-5412] Enable RocksDB tests on Windows OS

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3067

    [FLINK-5412] Enable RocksDB tests on Windows OS

    This PR re-enables several RocksDB tests.
    
    Furthermore, the `RocksDBStateBackendConfigTest#testSetDbPath` was modified to ensure that hte same normalization is applied to both the expected and actual paths.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5412_rocks_tests_enable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3067
    
----
commit 2dbc3c836ad42bbcfcc7264d1297fe876618d01c
Author: zentol <ch...@apache.org>
Date:   2017-01-05T15:18:38Z

    [FLINK-5412] Enable RocksDB tests on Windows OS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3067: [FLINK-5412] Enable RocksDB tests on Windows OS

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3067#discussion_r94793743
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java ---
    @@ -42,6 +40,7 @@
     import org.rocksdb.DBOptions;
     
     import java.io.File;
    +import java.nio.file.Files;
    --- End diff --
    
    Unused import?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3067: [FLINK-5412] Enable RocksDB tests on Windows OS

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/3067
  
    merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3067: [FLINK-5412] Enable RocksDB tests on Windows OS

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3067


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3067: [FLINK-5412] Enable RocksDB tests on Windows OS

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3067#discussion_r94798431
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java ---
    @@ -42,6 +40,7 @@
     import org.rocksdb.DBOptions;
     
     import java.io.File;
    +import java.nio.file.Files;
    --- End diff --
    
    yes, will fix it while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---