You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/01/09 07:34:00 UTC

[GitHub] zeppelin pull request #1876: [ZEPPELIN-1927] Remove useless function wrappin...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/1876

    [ZEPPELIN-1927] Remove useless function wrapping in all js files

    ### What is this PR for?
    
    Removed useless function wrappings to move toward `import`, `export` syntax. This PR will not affect on any previous functionalities.
    
    **This PR is not big! I did only 2 things.**
    
    - Removed `(function() {})()` which wraps a module.
    - Reindented whole files.
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [x] - Remove function wrappings
    * [x] - Reindent
    
    ### What is the Jira issue?
    
    [ZEPPELIN-1927](https://issues.apache.org/jira/browse/ZEPPELIN-1927)
    
    ### How should this be tested?
    
    CI will test this PR. 
    
    ### Screenshots (if appropriate)
    
    None
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1927/remove-useless-func-wrappings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1876
    
----
commit eb8772b2bc9d12de7b622e34b0d13e3008498a84
Author: 1ambda <1a...@gmail.com>
Date:   2017-01-09T07:11:48Z

    fix: Remove all function wrapping in js files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1876: [ZEPPELIN-1927] Remove useless function wrapping in al...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1876
  
    @Leemoonsoo 
    
    I'v just rebased


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1876: [ZEPPELIN-1927] Remove useless function wrapping in al...

Posted by cloverhearts <gi...@git.apache.org>.

Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1876
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1876: [ZEPPELIN-1927] Remove useless function wrappin...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1876


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1876: [ZEPPELIN-1927] Remove useless function wrapping in al...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1876
  
    LGTM and merge if no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---