You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/16 18:26:21 UTC

[GitHub] MaxGekk opened a new pull request #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType

MaxGekk opened a new pull request #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType
URL: https://github.com/apache/spark/pull/23811
 
 
   ## What changes were proposed in this pull request?
   
   In the PR, I propose to add new Catalyst type converter for `TimestampType`. It should be able to convert `java.time.Instant` to/from `TimestampType`.
   
   Main motivations for the changes:
   - Smoothly support Java 8 time API
   - Avoid inconsistency of calendars used inside of Spark 3.0 (Proleptic Gregorian calendar) and `java.sql.Timestamp` (hybrid calendar - Julian + Gregorian).
   - Make conversion independent from current system timezone.
   
   
   ## How was this patch tested?
   
   Added new testes to `CatalystTypeConvertersSuite` to check conversion of `TimestampType` to/from `java.time.Instant`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org