You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sis.apache.org by GitBox <gi...@apache.org> on 2022/07/28 17:20:44 UTC
[GitHub] [sis] alexismanin opened a new pull request, #28: fix(Core): add control points if required when converting an envelope to a polygon.
alexismanin opened a new pull request, #28:
URL: https://github.com/apache/sis/pull/28
On axes with potential wrap-around, if the envelope is very large, the conversion to a rectangle without additional control points create an ambiguity.
When trying to link two points of the rectangle using shortest path, the result could not follow rectangle edges, due to the wrap-around. Adding control points mitigate that problem.
Note: the current solution is only a quick fix, surely there is room for improvement. For example, the current solution only consider a single wrap-around period.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sis] desruisseaux commented on pull request #28: fix(Core): add control points if required when converting an envelope to a polygon.
Posted by GitBox <gi...@apache.org>.
desruisseaux commented on PR #28:
URL: https://github.com/apache/sis/pull/28#issuecomment-1221561133
The fix, which adds intermediate points during the "envelope to JTS" conversion, is modified in two ways:
* Instead of adding mid-points, add points on the edges of axis ranges (e.g. 180°E or 180°W).
* Disabled for now, because generally not needed after SIS-547 and SIS-486 new fixes.
We need to revisit what could be a public API for enabling the insertion of additional points on demand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sis] alexismanin commented on pull request #28: fix(Core): add control points if required when converting an envelope to a polygon.
Posted by GitBox <gi...@apache.org>.
alexismanin commented on PR #28:
URL: https://github.com/apache/sis/pull/28#issuecomment-1198428866
@desruisseaux I still cannot assign it to you. I'd like your review please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sis] asfgit merged pull request #28: fix(Core): add control points if required when converting an envelope to a polygon.
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #28:
URL: https://github.com/apache/sis/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org