You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/05/24 23:35:04 UTC

Review Request 59555: A prototype to move sample collection into async sampling.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59555/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

A prototype to move sample collection into async sampling.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/metrics.hpp 9c32a88d851c884a5025edb6ea1e27939b484546 
  3rdparty/libprocess/src/metrics/metrics.cpp 7184aa4d0294c20466646c9aa61d90973eca22e1 


Diff: https://reviews.apache.org/r/59555/diff/1/


Testing
-------

Ran this on a master and able to get result on `/metrics/cached` endpoint.


Thanks,

Zhitao Li


Re: Review Request 59555: A prototype to move sample collection into async sampling.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59555/#review176152
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot Windows


On May 24, 2017, 11:35 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59555/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A prototype to move sample collection into async sampling.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 9c32a88d851c884a5025edb6ea1e27939b484546 
>   3rdparty/libprocess/src/metrics/metrics.cpp 7184aa4d0294c20466646c9aa61d90973eca22e1 
> 
> 
> Diff: https://reviews.apache.org/r/59555/diff/1/
> 
> 
> Testing
> -------
> 
> Ran this on a master and able to get result on `/metrics/cached` endpoint.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Re: Review Request 59555: A prototype to move sample collection into async sampling.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59555/#review176075
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot


On May 24, 2017, 11:35 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59555/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A prototype to move sample collection into async sampling.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 9c32a88d851c884a5025edb6ea1e27939b484546 
>   3rdparty/libprocess/src/metrics/metrics.cpp 7184aa4d0294c20466646c9aa61d90973eca22e1 
> 
> 
> Diff: https://reviews.apache.org/r/59555/diff/1/
> 
> 
> Testing
> -------
> 
> Ran this on a master and able to get result on `/metrics/cached` endpoint.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>