[GitHub] [knox] smolnar82 commented on a change in pull request #269: KNOX-2239 - Websocket use the configured truststore in gateway-site config file

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #269: KNOX-2239 - Websocket use the configured truststore in gateway-site config file
URL: https://github.com/apache/knox/pull/269#discussion_r382935274
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/websockets/GatewayWebsocketHandler.java
 ##########
 @@ -118,14 +120,28 @@ public Object createWebSocket(ServletUpgradeRequest req,
       LOG.debugLog("Generated backend URL for websocket connection: " + backendURL);
 
       /* Upgrade happens here */
-      return new ProxyWebSocketAdapter
-              (URI.create(backendURL), pool, getClientEndpointConfig(req), config);
+      final ClientEndpointConfig clientConfig = getClientEndpointConfig(req);
+      clientConfig.getUserProperties().put("org.apache.knox.gateway.websockets.truststore", getTruststore());
 
 Review comment:
   nit: You may have wanted to introduce a constant for the new property name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services