You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org> on 2014/02/06 04:28:12 UTC
[jira] [Commented] (MAPREDUCE-5719) Potential null pointer access
in AbstractYarnScheduler#getTransferredContainers()
[ https://issues.apache.org/jira/browse/MAPREDUCE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892982#comment-13892982 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-5719:
----------------------------------------------------
Don't think null-check is the right solution - it will hide bugs. We already ran into a bug that we are fixing at YARN-1689. Let's not put this fix. Let's figure out what the real issue is.
> Potential null pointer access in AbstractYarnScheduler#getTransferredContainers()
> ---------------------------------------------------------------------------------
>
> Key: MAPREDUCE-5719
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5719
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: mapreduce-5719-v1.txt, mapreduce-5719-v2.txt, mapreduce-5719-v3.txt
>
>
> From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1666/console :
> {code}
> Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.12 sec <<< FAILURE! - in org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator
> testCompletedTasksRecalculateSchedule(org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator) Time elapsed: 2.083 sec <<< ERROR!
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NullPointerException
> at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getTransferredContainers(AbstractYarnScheduler.java:50)
> at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.registerApplicationMaster(ApplicationMasterService.java:277)
> at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.register(RMCommunicator.java:154)
> at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.register(TestRMContainerAllocator.java:1476)
> at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.serviceStart(RMCommunicator.java:112)
> at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.serviceStart(RMContainerAllocator.java:219)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.<init>(TestRMContainerAllocator.java:1444)
> at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$RecalculateContainerAllocator.<init>(TestRMContainerAllocator.java:1629)
> at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testCompletedTasksRecalculateSchedule(TestRMContainerAllocator.java:1665)
> {code}
> In above case getMasterContainer() returned null.
> AbstractYarnScheduler#getTransferredContainers() should check such condition.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)