You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/25 14:36:19 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3916: server:
fix issue while list ssh keypairs by keyword
ustcweizhou opened a new pull request #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916
## Description
in 4.13, list sshkeypairs with keyword will ignore the search by name if name is specifed.
Fixes an issue in #3098
for example,
```
(local) > list sshkeypairs name=wei keyword=wei filter=name
{
"count": 3,
"sshkeypair": [
{
"name": "wei3"
},
{
"name": "wei2"
},
{
"name": "wei"
}
]
}
```
with this patch ,it gives correct result.
```
(local) > list sshkeypairs name=wei keyword=wei filter=name
{
"count": 1,
"sshkeypair": [
{
"name": "wei"
}
]
}
```
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3916: server: fix issue
while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-590931429
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3916: server: fix
issue while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-590931885
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3916: server: fix
issue while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-590901166
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3916: server: fix issue
while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-590900923
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3916: server: fix issue
while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3916: server: fix
issue while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-590910739
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3916: server: fix
issue while list ssh keypairs by keyword
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3916: server: fix issue while list ssh keypairs by keyword
URL: https://github.com/apache/cloudstack/pull/3916#issuecomment-591140717
<b>Trillian test result (tid-1118)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27210 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3916-t1118-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 174.44 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 175.00 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 228.15 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services