[GitHub] [nifi] bbende commented on a change in pull request #3444: NIFI-6223 Expose Cluster Node Type to Controller Services

[GitBox <gi...@apache.org>]

bbende commented on a change in pull request #3444: NIFI-6223 Expose Cluster Node Type to Controller Services
URL: https://github.com/apache/nifi/pull/3444#discussion_r277693173
 
 

 ##########
 File path: nifi-mock/src/main/java/org/apache/nifi/util/MockControllerServiceInitializationContext.java
 ##########
 @@ -70,6 +71,11 @@ public StateManager getStateManager() {
         return stateManager;
     }
 
+    @Override
+    public NodeTypeProvider getNodeTypeProvider() {
+        return null;
 
 Review comment:
   I think we probably want a way to utilize the NodeTypeProvider from the mock framework. Looking at MockProcessorInitializationContext, it returns a MockProcessContext which implements NodeTypeProvider and also has methods like setClustered and setPrimary to simulate different scenarios. 
   
   We probably wouldn't use MockProcessContext here, but maybe we can make MockControllerServiceInitializationContext implement NodeType provider + have the setter methods, and then getNodeTypeProvider() returns this ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services