You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2020/09/29 15:09:26 UTC
[hadoop] branch branch-3.3 updated: HADOOP-17267. Add debug-level
logs in Filesystem.close() (#2321)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.3 by this push:
new 43c9959 HADOOP-17267. Add debug-level logs in Filesystem.close() (#2321)
43c9959 is described below
commit 43c9959b3aab272f12e668f176a7607ac7a78764
Author: Karen Coppage <ka...@gmail.com>
AuthorDate: Tue Sep 29 17:06:50 2020 +0200
HADOOP-17267. Add debug-level logs in Filesystem.close() (#2321)
When a filesystem is closed, the FileSystem log will, at debug level,
log the method calling close/closeAll.
At trace level: the full calling stack.
Contributed by Karen Coppage.
Change-Id: I1444f065c171fd31d42b497c92ba4517969f67f0
---
.../main/java/org/apache/hadoop/fs/FileSystem.java | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
index 86434c6..3ec7528 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
@@ -620,6 +620,7 @@ public abstract class FileSystem extends Configured
* @throws IOException a problem arose closing one or more filesystem.
*/
public static void closeAll() throws IOException {
+ debugLogFileSystemClose("closeAll", "");
CACHE.closeAll();
}
@@ -630,10 +631,24 @@ public abstract class FileSystem extends Configured
* @throws IOException a problem arose closing one or more filesystem.
*/
public static void closeAllForUGI(UserGroupInformation ugi)
- throws IOException {
+ throws IOException {
+ debugLogFileSystemClose("closeAllForUGI", "UGI: " + ugi);
CACHE.closeAll(ugi);
}
+ private static void debugLogFileSystemClose(String methodName,
+ String additionalInfo) {
+ if (LOGGER.isDebugEnabled()) {
+ Throwable throwable = new Throwable().fillInStackTrace();
+ LOGGER.debug("FileSystem.{}() by method: {}); {}", methodName,
+ throwable.getStackTrace()[2], additionalInfo);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace("FileSystem.{}() full stack trace:", methodName,
+ throwable);
+ }
+ }
+ }
+
/**
* Qualify a path to one which uses this FileSystem and, if relative,
* made absolute.
@@ -2569,6 +2584,9 @@ public abstract class FileSystem extends Configured
*/
@Override
public void close() throws IOException {
+ debugLogFileSystemClose("close", "Key: " + key + "; URI: " + getUri()
+ + "; Object Identity Hash: "
+ + Integer.toHexString(System.identityHashCode(this)));
// delete all files that were marked as delete-on-exit.
processDeleteOnExit();
CACHE.remove(this.key, this);
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org