[jira] [Commented] (ODE-967) Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO

["Tammo van Lessen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ODE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289356#comment-13289356 ] 

Tammo van Lessen commented on ODE-967:
--------------------------------------

Depending on how often getMessageExchangeIds is called, it would be better to use a Map instead of a Collection in order to avoid the additional effort of iterating over all MEX daos for each method invocation.
                
> Improvements to the the map of messageExchanges maintained at in-memory representation of process instance DAO
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: ODE-967
>                 URL: https://issues.apache.org/jira/browse/ODE-967
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Runtime
>    Affects Versions: 1.4
>         Environment: https://svn.apache.org/repos/asf/ode/trunk
>            Reporter: Denis Weerasiri
>              Labels: patch
>         Attachments: ODE-967-v1.patch
>
>
> I'm proposing this code level improvement to in-memory DAO implementation in bpel-runtime.
> In the in-memory representation of process instance DAO (org.apache.ode.bpel.memdao.ProcessInstanceDaoImpl), we see it maintains an unused map of messageExchanges.
> eg - private Map<String, byte[]> _messageExchanges = new HashMap<String, byte[]>();
> And the runtime representation of the message exchanges is quite weird as it's a byte array. But looking at the other DAO implementation, I think correct way to maintain a message exchange is to maintain a collection of org.apache.ode.bpel.dao.MessageExchangeDAO.
> Here I've attached a patch which describes the code-level improvement.
> Regards,
> Denis Weerasiri

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira