You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Paul Burba <pb...@collab.net> on 2007/06/18 15:00:18 UTC

Buildbot failure not reported

Due to a problem with merge_test-52 (mergeinfo can have empty rev ranges
the test) the test is failing spuriously.  I'm working on fix for that,
but did notice that the VS2005 build bot is reporting everything is
passing even though the test fails,
http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%20
fsfs%2Bra_local/0

...
Testing Release configuration on local repository.
...
Running all tests in merge_tests.py [33/50]...success
...
CMD: svn.exe "pl" "-vR"
"svn-test-work\working_copies\merge_tests-52.H\omega" "--config-dir"
"M:\svn-auto-test\fsfs\subversion\tests\cmdline\svn-test-work\local_tmp\
config" <TIME = 1.062000>

EXPECTED STDOUT:

Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':

  prop:name : propval

  svn:mergeinfo : /A_COPY/B/E/beta:5

/A_COPY/D/H/omega:3-4

ACTUAL STDOUT:

Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':

  prop:name : propval

  svn:mergeinfo : /A_COPY/B/E/beta:5


/A_COPY/D/H/omega:3-4

EXCEPTION: SVNLineUnequal

FAIL:  merge_tests.py 52: mergeinfo can have empty rev ranges
 <snip>
...

Anyone know what wrong here?

Paul
 

> -----Original Message-----
> From: buildbot@mobsol.be [mailto:buildbot@mobsol.be] 
> Sent: Monday, June 18, 2007 12:46 AM
> To: svn-breakage@subversion.tigris.org
> Subject: svn trunk r25439: PASS (win32-xp VS2005)
> 
> Full details are available at: 
> http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1779
> 
> Author list: bhuvan
> 
> Build Slave: djh-xp-vse2005
> 
> 
> Subversion Buildbot
> http://www.mobsol.be/buildbot/
> 
> 
> Last 100 lines of the build log (step: Cleanup ):
> 
>  Setting environment for using Microsoft Visual Studio 2005 x86 tools.
> Deleted file - 
> C:\svn-builder\djh-xp-vse2005\build\subversion_vcnet.sln
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-breakage-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: 
> svn-breakage-help@subversion.tigris.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: Buildbot failure not reported

Posted by "D.J. Heap" <dj...@gmail.com>.
On 6/18/07, Lieven Govaerts <sv...@mobsol.be> wrote:
[snip]
>
> While the tests are indeed failing, the overview doesn't show those failures:
>
> Running all tests in merge_tests.py [33/50]...success
> ..
> Running all tests in lock_tests.py [45/50]...success
> ..
>
> The cause must be somewhere in the test framework. I wonder, DJ, are you running
> the tests in parallel?
>


Yes, they are running in parallel as of a few hours after you
committed that change to win-tests.py...I can't remember exactly when
it was, but I took the buildbot offline for a few hours to try it out
before bringing it up again with the tests set for parallel.

It shaved off 20 or so mins, too...thanks for doing that work!

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Buildbot failure not reported

Posted by Lieven Govaerts <sv...@mobsol.be>.
Quoting Paul Burba <pb...@collab.net>:

> > -----Original Message-----
> > From: Kamesh Jayachandran
> > Sent: Monday, June 18, 2007 11:06 AM
> > To: Paul Burba
> > Cc: dev@subversion.tigris.org; D.J. Heap; Lieven Govaerts
> > Subject: Re: Buildbot failure not reported
> >
> > Paul,
> > I have fixed the failure via r25431.
>
> Kamesh,
>
> I saw that, the test still fails on Win32 though.  And the builbot
> report I linked to was for r25439 (after your fix) and it reported the
> tests as passing despite the failure clearly occurring in the log.
>
> Just check out this and you'll see what I mean:
>
> http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%20
> fsfs%2Bra_local/0
>
> I also just noticed that another test is failing:
>
> FAIL:  lock_tests.py 4: commit a locked file with a prop change

While the tests are indeed failing, the overview doesn't show those failures:

Running all tests in merge_tests.py [33/50]...success
..
Running all tests in lock_tests.py [45/50]...success
..

The cause must be somewhere in the test framework. I wonder, DJ, are you running
the tests in parallel?

Lieven

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Buildbot failure not reported

Posted by Lieven Govaerts <sv...@mobsol.be>.
Paul Burba wrote:
> I saw that, the test still fails on Win32 though.  And the builbot
> report I linked to was for r25439 (after your fix) and it reported the
> tests as passing despite the failure clearly occurring in the log.
>   
Ok, there are two issues, both related to running the tests in parallel.

First is Windows specific: the exit code of a spawned process is not set correctly (when using popen3). So basically, the result of running a suite of tests is always PASS. I fixed this in r25447.

> Just check out this and you'll see what I mean:
>
> http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%20
> fsfs%2Bra_local/0
>
> I also just noticed that another test is failing:
>
> FAIL:  lock_tests.py 4: commit a locked file with a prop change
>   
These are the last lines of stdout:
svn: Commit failed (details follow):
svn: User jconstant does not own lock on path '/A/mu' (currently locked by jrandom)

The problem here is that when I added the option to run the tests in
parallel, I looked at and found solutions to handle shared resources,
like the current working directory and the authz file. Unfortunately
there's one shared resource which I didn't take into account, and that's
the cached credentials. What went wrong here is that another of the lock
tests used user jconstant and cached it during an svn operation, and the
failing test is committing without explicitly passing the username
(jrandom) it wants to use for the commit.

We already discussed this a few weeks ago and I don't see any other
option than disabling all credentials caching and check all 450 tests to
see if they still work. Aaaarrgh :) I'll have a look at it.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Buildbot failure not reported

Posted by Paul Burba <pb...@collab.net>.
> -----Original Message-----
> From: Kamesh Jayachandran 
> Sent: Monday, June 18, 2007 11:06 AM
> To: Paul Burba
> Cc: dev@subversion.tigris.org; D.J. Heap; Lieven Govaerts
> Subject: Re: Buildbot failure not reported
> 
> Paul,
> I have fixed the failure via r25431.

Kamesh,

I saw that, the test still fails on Win32 though.  And the builbot
report I linked to was for r25439 (after your fix) and it reported the
tests as passing despite the failure clearly occurring in the log.

Just check out this and you'll see what I mean:

http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%20
fsfs%2Bra_local/0

I also just noticed that another test is failing:

FAIL:  lock_tests.py 4: commit a locked file with a prop change

Paul 
 
> With regards
> Kamesh Jayachandran
> Paul Burba wrote:
> > Due to a problem with merge_test-52 (mergeinfo can have empty rev 
> > ranges the test) the test is failing spuriously.  I'm 
> working on fix 
> > for that, but did notice that the VS2005 build bot is reporting 
> > everything is passing even though the test fails, 
> > 
> http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%
> > 20
> > fsfs%2Bra_local/0
> >
> > ...
> > Testing Release configuration on local repository.
> > ...
> > Running all tests in merge_tests.py [33/50]...success ...
> > CMD: svn.exe "pl" "-vR"
> > "svn-test-work\working_copies\merge_tests-52.H\omega" "--config-dir"
> > 
> "M:\svn-auto-test\fsfs\subversion\tests\cmdline\svn-test-work\local_tm
> > p\
> > config" <TIME = 1.062000>
> >
> > EXPECTED STDOUT:
> >
> > Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':
> >
> >   prop:name : propval
> >
> >   svn:mergeinfo : /A_COPY/B/E/beta:5
> >
> > /A_COPY/D/H/omega:3-4
> >
> > ACTUAL STDOUT:
> >
> > Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':
> >
> >   prop:name : propval
> >
> >   svn:mergeinfo : /A_COPY/B/E/beta:5
> >
> >
> > /A_COPY/D/H/omega:3-4
> >
> > EXCEPTION: SVNLineUnequal
> >
> > FAIL:  merge_tests.py 52: mergeinfo can have empty rev 
> ranges  <snip> 
> > ...
> >
> > Anyone know what wrong here?
> >
> > Paul
> >  
> >
> >   
> >> -----Original Message-----
> >> From: buildbot@mobsol.be [mailto:buildbot@mobsol.be]
> >> Sent: Monday, June 18, 2007 12:46 AM
> >> To: svn-breakage@subversion.tigris.org
> >> Subject: svn trunk r25439: PASS (win32-xp VS2005)
> >>
> >> Full details are available at: 
> >> http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1779
> >>
> >> Author list: bhuvan
> >>
> >> Build Slave: djh-xp-vse2005
> >>
> >>
> >> Subversion Buildbot
> >> http://www.mobsol.be/buildbot/
> >>
> >>
> >> Last 100 lines of the build log (step: Cleanup ):
> >>
> >>  Setting environment for using Microsoft Visual Studio 
> 2005 x86 tools.
> >> Deleted file -
> >> C:\svn-builder\djh-xp-vse2005\build\subversion_vcnet.sln
> >>
> >> 
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: 
> >> svn-breakage-unsubscribe@subversion.tigris.org
> >> For additional commands, e-mail: 
> >> svn-breakage-help@subversion.tigris.org
> >>
> >>
> >>     
> >
> > 
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: dev-help@subversion.tigris.org
> >
> >   
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: Buildbot failure not reported

Posted by Kamesh Jayachandran <ka...@collab.net>.
Paul,
I have fixed the failure via r25431.

With regards
Kamesh Jayachandran
Paul Burba wrote:
> Due to a problem with merge_test-52 (mergeinfo can have empty rev ranges
> the test) the test is failing spuriously.  I'm working on fix for that,
> but did notice that the VS2005 build bot is reporting everything is
> passing even though the test fails,
> http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/1779/step-Test%20
> fsfs%2Bra_local/0
>
> ...
> Testing Release configuration on local repository.
> ...
> Running all tests in merge_tests.py [33/50]...success
> ...
> CMD: svn.exe "pl" "-vR"
> "svn-test-work\working_copies\merge_tests-52.H\omega" "--config-dir"
> "M:\svn-auto-test\fsfs\subversion\tests\cmdline\svn-test-work\local_tmp\
> config" <TIME = 1.062000>
>
> EXPECTED STDOUT:
>
> Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':
>
>   prop:name : propval
>
>   svn:mergeinfo : /A_COPY/B/E/beta:5
>
> /A_COPY/D/H/omega:3-4
>
> ACTUAL STDOUT:
>
> Properties on 'svn-test-work\working_copies\merge_tests-52.H\omega':
>
>   prop:name : propval
>
>   svn:mergeinfo : /A_COPY/B/E/beta:5
>
>
> /A_COPY/D/H/omega:3-4
>
> EXCEPTION: SVNLineUnequal
>
> FAIL:  merge_tests.py 52: mergeinfo can have empty rev ranges
>  <snip>
> ...
>
> Anyone know what wrong here?
>
> Paul
>  
>
>   
>> -----Original Message-----
>> From: buildbot@mobsol.be [mailto:buildbot@mobsol.be] 
>> Sent: Monday, June 18, 2007 12:46 AM
>> To: svn-breakage@subversion.tigris.org
>> Subject: svn trunk r25439: PASS (win32-xp VS2005)
>>
>> Full details are available at: 
>> http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1779
>>
>> Author list: bhuvan
>>
>> Build Slave: djh-xp-vse2005
>>
>>
>> Subversion Buildbot
>> http://www.mobsol.be/buildbot/
>>
>>
>> Last 100 lines of the build log (step: Cleanup ):
>>
>>  Setting environment for using Microsoft Visual Studio 2005 x86 tools.
>> Deleted file - 
>> C:\svn-builder\djh-xp-vse2005\build\subversion_vcnet.sln
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: svn-breakage-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: 
>> svn-breakage-help@subversion.tigris.org
>>
>>
>>     
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>   

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org