You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by "Chris Westin (JIRA)" <ji...@apache.org> on 2015/05/08 20:12:00 UTC

[jira] [Created] (DRILL-2996) ValueVectors shouldn't call reAlloc() in a while() loop

Chris Westin created DRILL-2996:
-----------------------------------

             Summary: ValueVectors shouldn't call reAlloc() in a while() loop
                 Key: DRILL-2996
                 URL: https://issues.apache.org/jira/browse/DRILL-2996
             Project: Apache Drill
          Issue Type: Bug
          Components: Execution - Data Types
            Reporter: Chris Westin
            Assignee: Daniel Barclay (Drill)


Instead, reAlloc() should be change to take a "new minimum size" as an argument. This value is just the value used to determine the while loops' termination. Then reAlloc() can figure out how much more to allocate once and for all, instead of possibly reallocating and copying more than once, and it can make sure that the size doesn't overflow (we've seen some instances of the allocator being called with negative sizes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)