You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/18 09:02:04 UTC
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 1:02 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Changes
-------
Added `README.md`s and other bots to start off the `support/jenkins` directory.
Summary (updated)
-----------------
Added a `support/README.md` and the `support/jenkins` directory.
Repository: mesos
Description (updated)
-------
Added a `support/README.md` and the `support/jenkins` directory.
Diffs (updated)
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote:
> > support/jenkins/buildbot.sh, line 22
> > <https://reviews.apache.org/r/55491/diff/5/?file=1607399#file1607399line22>
> >
> > Any reason this isn't named `MESOS_DIRECTORY` like similar variables in other places?
See https://reviews.apache.org/r/55490/#comment233317
> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote:
> > support/jenkins/tidybot.sh, line 22
> > <https://reviews.apache.org/r/55491/diff/5/?file=1607401#file1607401line22>
> >
> > `MESOS_DIRECTORY`?
See https://reviews.apache.org/r/55490/#comment233317
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------
On Jan. 18, 2017, 7:12 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `support/README.md` and the `support/jenkins` directory.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote:
> > support/jenkins/reviewbot.sh, line 32
> > <https://reviews.apache.org/r/55491/diff/5/?file=1607400#file1607400line32>
> >
> > Hardcoding a password here seems like a pretty bad idea. Could we instead pass it in from the outside, e.g., via an environment variable?
> >
> > We very likely also need to soon change this password now since it is known to everybody.
I've figured out how to hide the password. I'll change the password shortly as well.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------
On Jan. 18, 2017, 8:38 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 8:38 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 18, 2017, 4:50 a.m., Benjamin Bannier wrote:
> > support/README.md, lines 5-7
> > <https://reviews.apache.org/r/55491/diff/5/?file=1607397#file1607397line5>
> >
> > > The scripts directly in this directory are intended to be used by Mesos developers, while the build scripts in [`jenkins`](jenkins) are used by the ASF Jenkins CI in a bot-specific way.
I decided to just drop the `jenkins` stuff. People can look at `jenkins/README.md`.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------
On Jan. 18, 2017, 7:12 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 7:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `support/README.md` and the `support/jenkins` directory.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162080
-----------------------------------------------------------
support/README.md (line 1)
<https://reviews.apache.org/r/55491/#comment233330>
> # Supporting tools
support/README.md (lines 5 - 7)
<https://reviews.apache.org/r/55491/#comment233329>
> The scripts directly in this directory are intended to be used by Mesos developers, while the build scripts in [`jenkins`](jenkins) are used by the ASF Jenkins CI in a bot-specific way.
support/jenkins/README.md (lines 5 - 6)
<https://reviews.apache.org/r/55491/#comment233331>
> The scripts named `<name>.sh` correspond to Jenkins jobs named ...
support/jenkins/buildbot.sh (line 22)
<https://reviews.apache.org/r/55491/#comment233332>
Any reason this isn't named `MESOS_DIRECTORY` like similar variables in other places?
support/jenkins/buildbot.sh (line 25)
<https://reviews.apache.org/r/55491/#comment233336>
Note sure it would be desirable to forcibly continue with the rest of the script if `pip` returns an error.
Note that `pip` would return `0` if `virtualenv` were already present.
support/jenkins/reviewbot.sh (line 32)
<https://reviews.apache.org/r/55491/#comment233337>
Hardcoding a password here seems like a pretty bad idea. Could we instead pass it in from the outside, e.g., via an environment variable?
We very likely also need to soon change this password now since it is known to everybody.
support/jenkins/tidybot.sh (line 22)
<https://reviews.apache.org/r/55491/#comment233338>
`MESOS_DIRECTORY`?
- Benjamin Bannier
On Jan. 18, 2017, 10:04 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 10:04 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162049
-----------------------------------------------------------
Fix it, then Ship it!
support/jenkins/reviewbot.sh (line 30)
<https://reviews.apache.org/r/55491/#comment233298>
Can you add a comment here on why we do this?
# Build the HEAD to make sure there are no errors prior to applying the review chain.
- Vinod Kone
On Jan. 18, 2017, 9:04 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 9:04 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162141
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Jan. 18, 2017, 5:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5:38 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162167
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55667, 55490, 55654, 55491]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 18, 2017, 4:38 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 4:38 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 8:38 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 8:38 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Changes
-------
Hid the password behind `PASSWORD` env var provided by the Jenkins job.
Repository: mesos
Description
-------
Added a `support/README.md` and the `support/jenkins` directory.
Diffs (updated)
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/#review162120
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55667, 55490, 55654, 55491]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos ReviewBot
On Jan. 18, 2017, 3:12 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55491/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 3:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `support/README.md` and the `support/jenkins` directory.
>
>
> Diffs
> -----
>
> support/README.md PRE-CREATION
> support/jenkins/README.md PRE-CREATION
> support/jenkins/buildbot.sh PRE-CREATION
> support/jenkins/reviewbot.sh PRE-CREATION
> support/jenkins/tidybot.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 7:12 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Changes
-------
Addressed Vinod and Benjamin's comments.
Repository: mesos
Description (updated)
-------
Added a `support/README.md` and the `support/jenkins` directory.
Diffs (updated)
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 1:04 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Changes
-------
Fixed a link in `README.md`
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55491: Added a `support/README.md` and the
`support/jenkins` directory.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55491/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 1:02 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
support/README.md PRE-CREATION
support/jenkins/README.md PRE-CREATION
support/jenkins/buildbot.sh PRE-CREATION
support/jenkins/reviewbot.sh PRE-CREATION
support/jenkins/tidybot.sh PRE-CREATION
Diff: https://reviews.apache.org/r/55491/diff/
Testing
-------
Thanks,
Michael Park