You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Devin Bost <de...@gmail.com> on 2021/05/01 00:08:29 UTC
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
If it's not too late, can we please also include:
https://github.com/apache/pulsar/pull/10389 ?
Devin G. Bost
On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
> <gu...@gmail.com> ha scritto:
> >
> > Can you include these two issues? I have marked them for 2.7.2.
>
> Sure, Penghui committed them.
>
>
> There are a few problems on branch-2.7 due to last minute cherry-picks
>
> I am sending PRs for fixes
> for instance this is a fix for a test that relied on "memory"
> MetadataStore, that is not available on branch-2.7
>
> https://github.com/apache/pulsar/pull/10453
>
> Enrico
>
>
> >
> > https://github.com/apache/pulsar/pull/10420
> > https://github.com/apache/pulsar/pull/10416
> >
> > Thanks,
> > Sijie
> >
> >
> > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hi fellows,
> > > I am preparing 2.7.2,
> > >
> > > I saw in this issue that Matteo added the label "release/2.7.2" and
> > > merged the issue to master branch.
> > > https://github.com/apache/pulsar/pull/10413
> > >
> > > Unfortunately in this case the PR is "closed" and marked for 2.7.2 so
> > > it looks like it has been committed to 2.7.2, but it is not true.
> > >
> > > Apart from that specific case,
> > > it is important to ping me directly if there is something that you
> > > want to include in 2.7.2.
> > >
> > > Otherwise the risk is that something that you think is in 2.7.2 it is
> not
> > > :-)
> > >
> > > I am verifying the commit log and checking for possible problems of
> this
> > > kind.
> > >
> > > I had to wait for a couple of blocker issue before proceeding for the
> > > release,
> > > not AFAIK it is time to proceed
> > >
> > > Enrico
> > >
>
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
Posted by Enrico Olivelli <eo...@gmail.com>.
FYI we needed to backport Athenz upgrade because Bintray repository is
no more available
https://github.com/apache/pulsar/pull/10471
many thanks to Lari for the quick backport
Enrico
Il giorno lun 3 mag 2021 alle ore 08:18 Enrico Olivelli
<eo...@gmail.com> ha scritto:
>
> Il giorno sab 1 mag 2021 alle ore 02:09 Devin Bost
> <de...@gmail.com> ha scritto:
> >
> > If it's not too late, can we please also include:
> > https://github.com/apache/pulsar/pull/10389 ?
>
> Included
>
> Enrico
>
> >
> > Devin G. Bost
> >
> >
> > On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > > Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
> > > <gu...@gmail.com> ha scritto:
> > > >
> > > > Can you include these two issues? I have marked them for 2.7.2.
> > >
> > > Sure, Penghui committed them.
> > >
> > >
> > > There are a few problems on branch-2.7 due to last minute cherry-picks
> > >
> > > I am sending PRs for fixes
> > > for instance this is a fix for a test that relied on "memory"
> > > MetadataStore, that is not available on branch-2.7
> > >
> > > https://github.com/apache/pulsar/pull/10453
> > >
> > > Enrico
> > >
> > >
> > > >
> > > > https://github.com/apache/pulsar/pull/10420
> > > > https://github.com/apache/pulsar/pull/10416
> > > >
> > > > Thanks,
> > > > Sijie
> > > >
> > > >
> > > > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <eo...@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi fellows,
> > > > > I am preparing 2.7.2,
> > > > >
> > > > > I saw in this issue that Matteo added the label "release/2.7.2" and
> > > > > merged the issue to master branch.
> > > > > https://github.com/apache/pulsar/pull/10413
> > > > >
> > > > > Unfortunately in this case the PR is "closed" and marked for 2.7.2 so
> > > > > it looks like it has been committed to 2.7.2, but it is not true.
> > > > >
> > > > > Apart from that specific case,
> > > > > it is important to ping me directly if there is something that you
> > > > > want to include in 2.7.2.
> > > > >
> > > > > Otherwise the risk is that something that you think is in 2.7.2 it is
> > > not
> > > > > :-)
> > > > >
> > > > > I am verifying the commit log and checking for possible problems of
> > > this
> > > > > kind.
> > > > >
> > > > > I had to wait for a couple of blocker issue before proceeding for the
> > > > > release,
> > > > > not AFAIK it is time to proceed
> > > > >
> > > > > Enrico
> > > > >
> > >
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno sab 1 mag 2021 alle ore 02:09 Devin Bost
<de...@gmail.com> ha scritto:
>
> If it's not too late, can we please also include:
> https://github.com/apache/pulsar/pull/10389 ?
Included
Enrico
>
> Devin G. Bost
>
>
> On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> > Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
> > <gu...@gmail.com> ha scritto:
> > >
> > > Can you include these two issues? I have marked them for 2.7.2.
> >
> > Sure, Penghui committed them.
> >
> >
> > There are a few problems on branch-2.7 due to last minute cherry-picks
> >
> > I am sending PRs for fixes
> > for instance this is a fix for a test that relied on "memory"
> > MetadataStore, that is not available on branch-2.7
> >
> > https://github.com/apache/pulsar/pull/10453
> >
> > Enrico
> >
> >
> > >
> > > https://github.com/apache/pulsar/pull/10420
> > > https://github.com/apache/pulsar/pull/10416
> > >
> > > Thanks,
> > > Sijie
> > >
> > >
> > > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > Hi fellows,
> > > > I am preparing 2.7.2,
> > > >
> > > > I saw in this issue that Matteo added the label "release/2.7.2" and
> > > > merged the issue to master branch.
> > > > https://github.com/apache/pulsar/pull/10413
> > > >
> > > > Unfortunately in this case the PR is "closed" and marked for 2.7.2 so
> > > > it looks like it has been committed to 2.7.2, but it is not true.
> > > >
> > > > Apart from that specific case,
> > > > it is important to ping me directly if there is something that you
> > > > want to include in 2.7.2.
> > > >
> > > > Otherwise the risk is that something that you think is in 2.7.2 it is
> > not
> > > > :-)
> > > >
> > > > I am verifying the commit log and checking for possible problems of
> > this
> > > > kind.
> > > >
> > > > I had to wait for a couple of blocker issue before proceeding for the
> > > > release,
> > > > not AFAIK it is time to proceed
> > > >
> > > > Enrico
> > > >
> >
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
Posted by Enrico Olivelli <eo...@gmail.com>.
Il Sab 1 Mag 2021, 07:50 Devin Bost <de...@gmail.com> ha scritto:
> As I just reported in that issue, to my great surprise, between my build
> from master that triggered that issue (which I created about 24 hours ago)
> and the build I just created (about 30 min ago), that issue is resolved...
> It looks like all the bug fix PRs merged over the last 24 hours are tagged
> to 2.7.2, so let's just ensure they're all included in the cut.
>
The PRs that are included have an additional label 'cherry picked to branch
2.7'
Enrico
> Devin G. Bost
>
>
> On Fri, Apr 30, 2021 at 10:12 PM Devin Bost <de...@gmail.com> wrote:
>
> > I just ran into a regression that appeared in the last 2-3 days of
> > commits, and it's preventing my function from starting. I reported it
> here:
> > https://github.com/apache/pulsar/issues/10460
> >
> > We need to ensure that issue isn't showing up in the cut of 2.7.2 before
> > we make the release official in case others are impacted. (Sometimes I
> > wonder if I'm the only one who runs into certain bugs, and it's possible
> > that's happening here, but we should double-check in case it affects a
> > larger audience.)
> >
> > Devin G. Bost
> >
> >
> > On Fri, Apr 30, 2021 at 6:08 PM Devin Bost <de...@gmail.com> wrote:
> >
> >> If it's not too late, can we please also include:
> >> https://github.com/apache/pulsar/pull/10389 ?
> >>
> >> Devin G. Bost
> >>
> >>
> >> On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com>
> >> wrote:
> >>
> >>> Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
> >>> <gu...@gmail.com> ha scritto:
> >>> >
> >>> > Can you include these two issues? I have marked them for 2.7.2.
> >>>
> >>> Sure, Penghui committed them.
> >>>
> >>>
> >>> There are a few problems on branch-2.7 due to last minute cherry-picks
> >>>
> >>> I am sending PRs for fixes
> >>> for instance this is a fix for a test that relied on "memory"
> >>> MetadataStore, that is not available on branch-2.7
> >>>
> >>> https://github.com/apache/pulsar/pull/10453
> >>>
> >>> Enrico
> >>>
> >>>
> >>> >
> >>> > https://github.com/apache/pulsar/pull/10420
> >>> > https://github.com/apache/pulsar/pull/10416
> >>> >
> >>> > Thanks,
> >>> > Sijie
> >>> >
> >>> >
> >>> > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <
> eolivelli@gmail.com>
> >>> > wrote:
> >>> >
> >>> > > Hi fellows,
> >>> > > I am preparing 2.7.2,
> >>> > >
> >>> > > I saw in this issue that Matteo added the label "release/2.7.2" and
> >>> > > merged the issue to master branch.
> >>> > > https://github.com/apache/pulsar/pull/10413
> >>> > >
> >>> > > Unfortunately in this case the PR is "closed" and marked for 2.7.2
> so
> >>> > > it looks like it has been committed to 2.7.2, but it is not true.
> >>> > >
> >>> > > Apart from that specific case,
> >>> > > it is important to ping me directly if there is something that you
> >>> > > want to include in 2.7.2.
> >>> > >
> >>> > > Otherwise the risk is that something that you think is in 2.7.2 it
> >>> is not
> >>> > > :-)
> >>> > >
> >>> > > I am verifying the commit log and checking for possible problems of
> >>> this
> >>> > > kind.
> >>> > >
> >>> > > I had to wait for a couple of blocker issue before proceeding for
> the
> >>> > > release,
> >>> > > not AFAIK it is time to proceed
> >>> > >
> >>> > > Enrico
> >>> > >
> >>>
> >>
>
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
Posted by Devin Bost <de...@gmail.com>.
As I just reported in that issue, to my great surprise, between my build
from master that triggered that issue (which I created about 24 hours ago)
and the build I just created (about 30 min ago), that issue is resolved...
It looks like all the bug fix PRs merged over the last 24 hours are tagged
to 2.7.2, so let's just ensure they're all included in the cut.
Devin G. Bost
On Fri, Apr 30, 2021 at 10:12 PM Devin Bost <de...@gmail.com> wrote:
> I just ran into a regression that appeared in the last 2-3 days of
> commits, and it's preventing my function from starting. I reported it here:
> https://github.com/apache/pulsar/issues/10460
>
> We need to ensure that issue isn't showing up in the cut of 2.7.2 before
> we make the release official in case others are impacted. (Sometimes I
> wonder if I'm the only one who runs into certain bugs, and it's possible
> that's happening here, but we should double-check in case it affects a
> larger audience.)
>
> Devin G. Bost
>
>
> On Fri, Apr 30, 2021 at 6:08 PM Devin Bost <de...@gmail.com> wrote:
>
>> If it's not too late, can we please also include:
>> https://github.com/apache/pulsar/pull/10389 ?
>>
>> Devin G. Bost
>>
>>
>> On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
>>> <gu...@gmail.com> ha scritto:
>>> >
>>> > Can you include these two issues? I have marked them for 2.7.2.
>>>
>>> Sure, Penghui committed them.
>>>
>>>
>>> There are a few problems on branch-2.7 due to last minute cherry-picks
>>>
>>> I am sending PRs for fixes
>>> for instance this is a fix for a test that relied on "memory"
>>> MetadataStore, that is not available on branch-2.7
>>>
>>> https://github.com/apache/pulsar/pull/10453
>>>
>>> Enrico
>>>
>>>
>>> >
>>> > https://github.com/apache/pulsar/pull/10420
>>> > https://github.com/apache/pulsar/pull/10416
>>> >
>>> > Thanks,
>>> > Sijie
>>> >
>>> >
>>> > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <eo...@gmail.com>
>>> > wrote:
>>> >
>>> > > Hi fellows,
>>> > > I am preparing 2.7.2,
>>> > >
>>> > > I saw in this issue that Matteo added the label "release/2.7.2" and
>>> > > merged the issue to master branch.
>>> > > https://github.com/apache/pulsar/pull/10413
>>> > >
>>> > > Unfortunately in this case the PR is "closed" and marked for 2.7.2 so
>>> > > it looks like it has been committed to 2.7.2, but it is not true.
>>> > >
>>> > > Apart from that specific case,
>>> > > it is important to ping me directly if there is something that you
>>> > > want to include in 2.7.2.
>>> > >
>>> > > Otherwise the risk is that something that you think is in 2.7.2 it
>>> is not
>>> > > :-)
>>> > >
>>> > > I am verifying the commit log and checking for possible problems of
>>> this
>>> > > kind.
>>> > >
>>> > > I had to wait for a couple of blocker issue before proceeding for the
>>> > > release,
>>> > > not AFAIK it is time to proceed
>>> > >
>>> > > Enrico
>>> > >
>>>
>>
Re: Cutting 2.7.2 - please ping be for adding last-minute issues
Posted by Devin Bost <de...@gmail.com>.
I just ran into a regression that appeared in the last 2-3 days of commits,
and it's preventing my function from starting. I reported it here:
https://github.com/apache/pulsar/issues/10460
We need to ensure that issue isn't showing up in the cut of 2.7.2 before we
make the release official in case others are impacted. (Sometimes I wonder
if I'm the only one who runs into certain bugs, and it's possible that's
happening here, but we should double-check in case it affects a larger
audience.)
Devin G. Bost
On Fri, Apr 30, 2021 at 6:08 PM Devin Bost <de...@gmail.com> wrote:
> If it's not too late, can we please also include:
> https://github.com/apache/pulsar/pull/10389 ?
>
> Devin G. Bost
>
>
> On Fri, Apr 30, 2021 at 1:01 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
>> Il giorno gio 29 apr 2021 alle ore 20:57 Sijie Guo
>> <gu...@gmail.com> ha scritto:
>> >
>> > Can you include these two issues? I have marked them for 2.7.2.
>>
>> Sure, Penghui committed them.
>>
>>
>> There are a few problems on branch-2.7 due to last minute cherry-picks
>>
>> I am sending PRs for fixes
>> for instance this is a fix for a test that relied on "memory"
>> MetadataStore, that is not available on branch-2.7
>>
>> https://github.com/apache/pulsar/pull/10453
>>
>> Enrico
>>
>>
>> >
>> > https://github.com/apache/pulsar/pull/10420
>> > https://github.com/apache/pulsar/pull/10416
>> >
>> > Thanks,
>> > Sijie
>> >
>> >
>> > On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli <eo...@gmail.com>
>> > wrote:
>> >
>> > > Hi fellows,
>> > > I am preparing 2.7.2,
>> > >
>> > > I saw in this issue that Matteo added the label "release/2.7.2" and
>> > > merged the issue to master branch.
>> > > https://github.com/apache/pulsar/pull/10413
>> > >
>> > > Unfortunately in this case the PR is "closed" and marked for 2.7.2 so
>> > > it looks like it has been committed to 2.7.2, but it is not true.
>> > >
>> > > Apart from that specific case,
>> > > it is important to ping me directly if there is something that you
>> > > want to include in 2.7.2.
>> > >
>> > > Otherwise the risk is that something that you think is in 2.7.2 it is
>> not
>> > > :-)
>> > >
>> > > I am verifying the commit log and checking for possible problems of
>> this
>> > > kind.
>> > >
>> > > I had to wait for a couple of blocker issue before proceeding for the
>> > > release,
>> > > not AFAIK it is time to proceed
>> > >
>> > > Enrico
>> > >
>>
>