You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/02/22 10:15:00 UTC

[jira] [Commented] (OFBIZ-11014) StringUtil cleanup

    [ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819573#comment-17819573 ] 

ASF subversion and git services commented on OFBIZ-11014:
---------------------------------------------------------

Commit 65be575cdd1a2712a0e9b38603f4339952d79f60 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=65be575cdd ]

Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)

As mentioned by Mathieu in (OFBIZ-11014)
https://github.com/apache/ofbiz-framework/commit/aa874841cea2652dc193b919120fa77a9d50184f

<<This test has been disabled since 2014 in revision 1648403, so it is not evident
if it is still relevant. Maybe should simply remove it.>>

It uses @Ignore("Failing test") so better remove it


> StringUtil cleanup
> ------------------
>
>                 Key: OFBIZ-11014
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11014
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Mathieu Lirzin
>            Assignee: Mathieu Lirzin
>            Priority: Minor
>         Attachments: OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch, OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch, OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch, OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch, OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch, OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch, OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch, OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch, OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch, OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch, OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch, OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch, OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch, OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch, OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java. For example the {{StringUtil#split}} method could be replaced by the {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)