You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/25 14:36:24 UTC
[GitHub] [nifi] gresockj opened a new pull request #4686: NIFI-8036: Adding es.failure.reason to PutHttpProcessor
gresockj opened a new pull request #4686:
URL: https://github.com/apache/nifi/pull/4686
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_NIFI-8036: Adds flow file attribute with failure reason in PutElasticsearchHttp processor._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on pull request #4686: NIFI-8036: Adding es.failure.reason to PutHttpProcessor
Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #4686:
URL: https://github.com/apache/nifi/pull/4686#issuecomment-814051314
This is OBE, as the "reason" attribute already puts the failure reason in a flowfile attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #4686: NIFI-8036: Adding es.failure.reason to PutHttpProcessor
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #4686:
URL: https://github.com/apache/nifi/pull/4686#discussion_r530569380
##########
File path: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttp.java
##########
@@ -356,6 +363,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
errorReason = reason;
logger.error("Failed to process {} due to {}, transferring to failure",
new Object[]{flowFile, errorReason});
+ flowFile = session.putAttribute(flowFile, "es.failure.reason", errorReason);
Review comment:
Reviewing this line in comparison to line 369, is there any difference between the `es.failure.reason` and `reason` attributes? If the values are the same in practice, then perhaps just updating the WritesAttribute annotation to add the `reason` attribute would be helpful.
As listed in the PR checklist, introducing a unit test to evaluate the presence of the attribute on failure would also be useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj closed pull request #4686: NIFI-8036: Adding es.failure.reason to PutHttpProcessor
Posted by GitBox <gi...@apache.org>.
gresockj closed pull request #4686:
URL: https://github.com/apache/nifi/pull/4686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org