You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/09 21:42:56 UTC

[GitHub] [pulsar] sijie commented on pull request #11468: [Function worker] Load ServiceConfiguration from file, not from Worke…

sijie commented on pull request #11468:
URL: https://github.com/apache/pulsar/pull/11468#issuecomment-895570433


   First of all, this ticket should be marked as `doc-required` as it introduces a different behavior to load customized settings.
   
   Secondly, the worker is designed to load settings from the worker file config, not from the broker file config. I don't think we should change the constructor to pass in another broker service configuration object. Why can't we access the underlying key/value map from the worker config object?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org