You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/01 10:26:09 UTC
[GitHub] [iotdb] zyk990424 commented on a change in pull request #3796: [IOTDB-1543] LastCache for Template and Vector
zyk990424 commented on a change in pull request #3796:
URL: https://github.com/apache/iotdb/pull/3796#discussion_r700083849
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
##########
@@ -1158,9 +1164,24 @@ private void tryToUpdateInsertLastCache(InsertRowPlan plan, Long latestFlushedTi
}
IMeasurementMNode[] mNodes = plan.getMeasurementMNodes();
int columnIndex = 0;
- for (IMeasurementMNode mNode : mNodes) {
- // Don't update cached last value for vector type
- if (!plan.isAligned()) {
+ if (plan.isAligned()) {
+ for (IMeasurementMNode mNode : mNodes) {
+ if (plan.getValues()[columnIndex] == null) {
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org