You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/17 09:27:16 UTC

[GitHub] [flink] AHeise commented on a change in pull request #10567: [FLINK-15244][FileSystems] Fix the bug that FileUtils#deleteDirectoryInternal will delete files in the symbolic link which point to a directory.

AHeise commented on a change in pull request #10567: [FLINK-15244][FileSystems] Fix the bug that FileUtils#deleteDirectoryInternal will delete files in the symbolic link which point to a directory.
URL: https://github.com/apache/flink/pull/10567#discussion_r358674530
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/util/FileUtilsTest.java
 ##########
 @@ -202,6 +202,24 @@ public void testDeleteDirectoryWhichIsAFile() throws Exception {
 		}
 	}
 
+	@Test
+	public void testDeleteSymbolicLinkDirectory() throws Exception {
+
+		// deleting a symbolic link directory should not delete the files in it.
+
+		File symbolicLinkDirectory = tmp.newFolder();
+		File symbolicLinkDirectoryChild = new File(symbolicLinkDirectory, "child");
+		//noinspection ResultOfMethodCallIgnored
 
 Review comment:
   same as above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services