You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by pzrq <gi...@git.apache.org> on 2016/04/18 04:39:01 UTC

[GitHub] libcloud pull request: [WIP] Py3.x lxml

GitHub user pzrq opened a pull request:

    https://github.com/apache/libcloud/pull/762

    [WIP] Py3.x lxml

    ## Python 3.x + lxml errors
    
    ### Description
    
    WIP: Seeing if I can reproduce test failures I have locally on tox on Travis as well.
    
    ### Status
    
    - work in progress
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mathspace/libcloud py3.5-lxml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #762
    
----
commit 48a02a628a05424ce88affe88f8b52203f8f8adb
Author: Peter Schmidt <pe...@peterjs.com>
Date:   2016-04-18T01:44:24Z

    Add py3.5-lxml to tox.ini
    
    So I can construct a bytes vs str test case that fails reproducibly under Python 3. Turned out there were already several so no need:
    
    ERROR: test_create_group_location_does_not_exist (libcloud.test.compute.test_abiquo.AbiquoNodeDriverTest)
    ...(not all 595 errors shown)
    ERROR: test_update_target (libcloud.test.backup.test_dimensiondata.DimensionDataTests)
    ERROR: test_update_target_DEFAULT (libcloud.test.backup.test_dimensiondata.DimensionDataTests)
    ERROR: test_update_target_STR (libcloud.test.backup.test_dimensiondata.DimensionDataTests)
    FAIL: test_wait_until_running_running_multiple_nodes_have_same_uuid (libcloud.test.compute.test_deployment.DeploymentTests)
    FAIL: test_wait_until_running_running_node_missing_from_list_nodes (libcloud.test.compute.test_deployment.DeploymentTests)
    FAIL: test_wait_until_running_timeout (libcloud.test.compute.test_deployment.DeploymentTests)
    FAIL: test_ex_set_control_access (libcloud.test.compute.test_vcloud.VCloud_1_5_Tests)
    FAILED (failures=4, errors=595, skipped=14)
    
    Others can let me know if it's a worthwhile trade off to add lxml testing against all environments.

commit 2f4bf6989038eead53c04c6c3791d73f1c251575
Author: Peter Schmidt <pe...@peterjs.com>
Date:   2016-04-18T02:07:52Z

    [WIP] Add Python 3.5-lxml to travis

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request: [Ideas welcome] Should lxml be properly sup...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/762


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---