You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/05 00:59:24 UTC
[GitHub] [kafka] bertber opened a new pull request #9699: MINOR: add a description for calling resetToDatetime's function to re…
bertber opened a new pull request #9699:
URL: https://github.com/apache/kafka/pull/9699
…setByDuration
Add a request that it will call resetToDatetime of description to resetByDuration of function.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9699: MINOR: remove duplicate code from resetByDuration
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9699:
URL: https://github.com/apache/kafka/pull/9699
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9699: MINOR: remove duplicate code from resetByDuration
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#discussion_r538962333
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -491,17 +491,8 @@ private void resetByDuration(final Consumer<byte[], byte[]> client,
final Duration duration) {
final Instant now = Instant.now();
Review comment:
Could we remove those local variables? For example:
```java
resetToDatetime(client, inputTopicPartitions, Instant.now().minus(duration).toEpochMilli());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bertber commented on pull request #9699: MINOR: add a description for calling resetToDatetime's function to resetByDuration and remove unnecessary loop code
Posted by GitBox <gi...@apache.org>.
bertber commented on pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#issuecomment-739097621
Hello! I have updated StreamsResetter of class.
I add a description for calling resetToDatetime's function to resetByDuration and remove unnecessary loop code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9699: MINOR: add a description for calling resetToDatetime's function to resetByDuration and remove duplicate code from resetByDuration
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#issuecomment-739498884
@bertber Thanks for your patch. Could you rebase code to include https://github.com/apache/kafka/commit/b9640a71c42ad117ed418209f87dc2962173469d?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bertber commented on a change in pull request #9699: MINOR: remove duplicate code from resetByDuration
Posted by GitBox <gi...@apache.org>.
bertber commented on a change in pull request #9699:
URL: https://github.com/apache/kafka/pull/9699#discussion_r539354420
##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -491,17 +491,8 @@ private void resetByDuration(final Consumer<byte[], byte[]> client,
final Duration duration) {
final Instant now = Instant.now();
Review comment:
Thank you for your information. I have updated this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org