You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 22:03:03 UTC

[GitHub] [arrow-datafusion] jdye64 opened a new issue, #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

jdye64 opened a new issue, #2321:
URL: https://github.com/apache/arrow-datafusion/issues/2321

   A section in `CONTRIBUTING.md` for `Code Formatting` would be useful for new developers to understand patterns, standards, and also prevent unnecessary commits with linter errors.
   
   **Describe the solution you'd like**
   A short section in `CONTRIBUTING.md` explaining to new devs how to format their code from the cli and as part of pre-commit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] timvw commented on issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

Posted by GitBox <gi...@apache.org>.
timvw commented on issue #2321:
URL: https://github.com/apache/arrow-datafusion/issues/2321#issuecomment-1117644083

   I tried to capture most of them in my PR [commit](https://github.com/apache/arrow-datafusion/pull/2394/commits/6ea9dbb0d3846a30847aacf2a84aae260009c5c9). (Because I managed to have failing builds due to these checks a couple of times 😛 )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #2321:
URL: https://github.com/apache/arrow-datafusion/issues/2321#issuecomment-1500431832

   Closed in https://github.com/apache/arrow-datafusion/pull/2444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jdye64 commented on issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

Posted by GitBox <gi...@apache.org>.
jdye64 commented on issue #2321:
URL: https://github.com/apache/arrow-datafusion/issues/2321#issuecomment-1107477556

   Yes, it really doesn't have to be much. Maybe a sentence explaining how to optionally install pre-commit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 commented on issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

Posted by GitBox <gi...@apache.org>.
xudong963 commented on issue #2321:
URL: https://github.com/apache/arrow-datafusion/issues/2321#issuecomment-1107475199

   I think we just need to add explict hint?  Such as please run `cargo fmt` & `cargo lint` before committing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #2321: [doc] Add code formatting instructions to CONTRIBUTING.md
URL: https://github.com/apache/arrow-datafusion/issues/2321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org