You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2015/05/28 09:35:17 UTC

[jira] [Updated] (OAK-2711) Troublesome AbstractTree.toString

     [ https://issues.apache.org/jira/browse/OAK-2711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chetan Mehrotra updated OAK-2711:
---------------------------------
    Attachment: OAK-2711.patch

[patch|^OAK-2711.patch] which only dumps child node names upto 5. 

[~anchela] [~mduerig] Would this be sufficient. 

There is still a possibility of large MVP flooding which would require fixing {{AbstractPropertyState#toString(PropertyState)}} but that would involve checking if return value is a list then limit that

> Troublesome AbstractTree.toString
> ---------------------------------
>
>                 Key: OAK-2711
>                 URL: https://issues.apache.org/jira/browse/OAK-2711
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>              Labels: technical_debt
>             Fix For: 1.3.0
>
>         Attachments: OAK-2711.patch
>
>
> the default {{toString}} for all tree implementations calculates a string containing the path, the toString of all properties as well as the names of all child tree... this is prone to cause troubles in case for trees that have plenty of properties and children.
> i would strongly recommend to review this and make the toString of trees both meaningful and cheap.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)