You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "aahmed-se (GitHub)" <gi...@apache.org> on 2018/08/23 21:37:26 UTC

[GitHub] [incubator-pulsar] aahmed-se opened pull request #2434: Add pulsar flink connectors

We Introduce a module for simple pulsar connectors for flink.

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
run java8 tests

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on pull request #2434: Add pulsar flink connectors

Posted by "sijie (GitHub)" <gi...@apache.org>.
can you move these properties to root pom file (where is the the central place for placing properties)?

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] aahmed-se commented on issue #2434: Add pulsar flink sink connector

Posted by "aahmed-se (GitHub)" <gi...@apache.org>.
should be fixed

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink connectors

Posted by "sijie (GitHub)" <gi...@apache.org>.
Created a master ticket for all the efforts related to flink connectors.

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink connectors

Posted by "sijie (GitHub)" <gi...@apache.org>.
Created a master ticket for all the efforts related to flink connectors #2441 

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
retest this please

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on pull request #2434: Add pulsar flink connectors

Posted by "sijie (GitHub)" <gi...@apache.org>.
"pulsar-storm-shade" => "pulsar-flink-shade"

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
@aahmed-se : since we are moving other people's PR into pulsar's repo, it is important to mention the original work and credits to the original author @XiaoZYang .

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
retest this please

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie closed pull request #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
[ pull request closed by sijie ]

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-pulsar] sijie commented on issue #2434: Add pulsar flink sink connector

Posted by "sijie (GitHub)" <gi...@apache.org>.
@aahmed-se there are some license header issues. PTAL

```
2018-08-27\T\19:50:00.378 [ERROR] Failed to execute goal com.mycila:license-maven-plugin:3.0.rc1:check (default-cli) on project pulsar-flink: Some files do not have the expected license header -> [Help 1]
```

[ Full content available at: https://github.com/apache/incubator-pulsar/pull/2434 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org