You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2014/10/14 01:12:43 UTC

git commit: CB-7204 - Race condition when hiding and showing spinner (closes #21)

Repository: cordova-plugin-splashscreen
Updated Branches:
  refs/heads/master c67622f1b -> d2e62a551


CB-7204 - Race condition when hiding and showing spinner (closes #21)


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/commit/d2e62a55
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/tree/d2e62a55
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/diff/d2e62a55

Branch: refs/heads/master
Commit: d2e62a551c950041cb4c9683624a04d931f4bee3
Parents: c67622f
Author: Shazron Abdullah <sh...@apache.org>
Authored: Mon Oct 13 16:11:42 2014 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Mon Oct 13 16:11:42 2014 -0700

----------------------------------------------------------------------
 src/ios/CDVSplashScreen.m | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-splashscreen/blob/d2e62a55/src/ios/CDVSplashScreen.m
----------------------------------------------------------------------
diff --git a/src/ios/CDVSplashScreen.m b/src/ios/CDVSplashScreen.m
index 4b4d466..f65a501 100644
--- a/src/ios/CDVSplashScreen.m
+++ b/src/ios/CDVSplashScreen.m
@@ -292,13 +292,15 @@
                           duration:fadeDuration
                            options:UIViewAnimationOptionTransitionNone
                         animations:^(void) {
-            [_imageView setAlpha:0];
-            [_activityView setAlpha:0];
-        }
-
+                            [_imageView setAlpha:0];
+                            [_activityView setAlpha:0];
+                        }
                         completion:^(BOOL finished) {
-            [self destroyViews];
-        }];
+                            if (finished) {
+                                [self destroyViews];
+                            }
+                        }
+        ];
     }
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org