[GitHub] [arrow] mapleFU commented on a diff in pull request #35758: GH-35757: [C++][Parquet] using page-encoding-stats to build encodings

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35758:
URL: https://github.com/apache/arrow/pull/35758#discussion_r1205056466


##########
cpp/src/parquet/metadata.cc:
##########
@@ -1462,40 +1462,45 @@ class ColumnChunkMetaDataBuilder::ColumnChunkMetaDataBuilderImpl {
     column_chunk_->meta_data.__set_total_compressed_size(compressed_size);
 
     std::vector<format::Encoding::type> thrift_encodings;
+    std::vector<format::PageEncodingStats> thrift_encoding_stats;
+    // Force Emplace encoding for RL/DL.
+    thrift_encodings.push_back(ToThrift(Encoding::RLE));

Review Comment:
   Oops, I just keep the logic here as before. It's ok to add or remove it :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org