[jira] [Commented] (PROTON-678) proton-c: (Win 32-bit) pn_post_frame misinterprets variable argument data when ERROR is used

["Andrew Stitcher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145507#comment-14145507 ] 

Andrew Stitcher commented on PROTON-678:
----------------------------------------

This fix makes no sense (with the current codebase in any case):

transport.c doesn't transitively include any windows platform headers files so the only ERROR symbol it can get is from protocol.h.

And there seems to be no problem building on Windows presently.

Perhaps the issue is in the client code somewhere, or could you replicate and explain this problem better.

> proton-c: (Win 32-bit) pn_post_frame misinterprets variable argument data when ERROR is used
> --------------------------------------------------------------------------------------------
>
>                 Key: PROTON-678
>                 URL: https://issues.apache.org/jira/browse/PROTON-678
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: 0.7
>         Environment: Windows x86-32
>            Reporter: Dominic Evans
>            Assignee: Andrew Stitcher
>         Attachments: 27_32bit_windows_fix_transport.c.patch
>
>
> For Windows 32bit ERROR is not a uint64_t type, which causes     pn_post_frame to misinterpret the passed variable argument data when ERROR is used 
> patch attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)