You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/14 05:56:14 UTC
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request
#399: HDDS-2424. Add the recover-trash command server side handling.
bharatviswa504 commented on a change in pull request #399: HDDS-2424. Add the recover-trash command server side handling.
URL: https://github.com/apache/hadoop-ozone/pull/399#discussion_r379261600
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2237,13 +2237,22 @@ public void deleteKey(OmKeyArgs args) throws IOException {
}
}
- // TODO: HDDS-2424. recover-trash command server side handling.
@Override
public boolean recoverTrash(String volumeName, String bucketName,
String keyName, String destinationBucket) throws IOException {
- boolean recoverOperation = true;
- return recoverOperation;
+ if (isAclEnabled) {
Review comment:
We don't need this anymore. As OMTrashRecoverRequest is handling recover request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org