You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/12 18:12:00 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4432: #4401 Reuse a ThreadLocal byte[] when reading String
elements from the variable length value reader.
Jackie-Jiang commented on a change in pull request #4432: #4401 Reuse a ThreadLocal byte[] when reading String elements from the variable length value reader.
URL: https://github.com/apache/incubator-pinot/pull/4432#discussion_r303089268
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
##########
@@ -72,9 +72,9 @@ public static String decodeUtf8(byte[] bytes) {
return decodeUtf8(bytes, 0, bytes.length);
}
- public static String decodeUtf8(byte[] bytes, int startIndex, int endIndex) {
+ public static String decodeUtf8(byte[] bytes, int startIndex, int length) {
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org