You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by andytaylor <gi...@git.apache.org> on 2017/10/18 09:00:31 UTC
[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/1593
ARTEMIS-1463 - added SSL example + docs
also added support for anon login
https://issues.apache.org/jira/browse/ARTEMIS-1463
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andytaylor/activemq-artemis rbac
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1593
----
commit 8dddeccca45e63c7616432a7ee4bd81327d93bb8
Author: Andy Taylor <an...@gmail.com>
Date: 2017-10-18T08:58:39Z
ARTEMIS-1463 - added SSL example + docs
also added support for anon login
https://issues.apache.org/jira/browse/ARTEMIS-1463
----
---
[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1593#discussion_r145409876
--- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java ---
@@ -75,9 +75,11 @@ public static void main(final String[] args) throws Exception {
// Step 7. Use JMX to retrieve the message counters using the JMSQueueControl
ObjectName on = ObjectNameBuilder.DEFAULT.getQueueObjectName(SimpleString.toSimpleString(queue.getQueueName()), SimpleString.toSimpleString(queue.getQueueName()), RoutingType.ANYCAST);
+ //we dont actually need credentials as the guest login i sused but this is how its done
HashMap env = new HashMap();
String[] creds = {"guest", "guest"};
env.put(JMXConnector.CREDENTIALS, creds);
+ env.put(JMXConnector.CREDENTIALS, creds);
--- End diff --
Was this a mistake? the double line here.
---
[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1593
---
[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1593#discussion_r145416142
--- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java ---
@@ -75,9 +75,11 @@ public static void main(final String[] args) throws Exception {
// Step 7. Use JMX to retrieve the message counters using the JMSQueueControl
ObjectName on = ObjectNameBuilder.DEFAULT.getQueueObjectName(SimpleString.toSimpleString(queue.getQueueName()), SimpleString.toSimpleString(queue.getQueueName()), RoutingType.ANYCAST);
+ //we dont actually need credentials as the guest login i sused but this is how its done
HashMap env = new HashMap();
String[] creds = {"guest", "guest"};
env.put(JMXConnector.CREDENTIALS, creds);
+ env.put(JMXConnector.CREDENTIALS, creds);
--- End diff --
fixed
---
[GitHub] activemq-artemis pull request #1593: ARTEMIS-1463 - added SSL example + docs
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1593#discussion_r145415855
--- Diff: examples/features/standard/message-counters/src/main/java/org/apache/activemq/artemis/jms/example/MessageCounterExample.java ---
@@ -75,9 +75,11 @@ public static void main(final String[] args) throws Exception {
// Step 7. Use JMX to retrieve the message counters using the JMSQueueControl
ObjectName on = ObjectNameBuilder.DEFAULT.getQueueObjectName(SimpleString.toSimpleString(queue.getQueueName()), SimpleString.toSimpleString(queue.getQueueName()), RoutingType.ANYCAST);
+ //we dont actually need credentials as the guest login i sused but this is how its done
HashMap env = new HashMap();
String[] creds = {"guest", "guest"};
env.put(JMXConnector.CREDENTIALS, creds);
+ env.put(JMXConnector.CREDENTIALS, creds);
--- End diff --
yes :)
---