You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2016/01/26 18:53:09 UTC

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

GitHub user kishorvpatil opened a pull request:

    https://github.com/apache/storm/pull/1048

    [STORM-1503] Worker should not crash on failure to send heartbeats to Pacemaker/ZK

    - Worker should catch and log Exception related to sending worker heartbeats to ZK/pacemaker.
    - `PacemakerClient` should not leave open previous channels.. If successfully reconnected - made new `Channel`. This avoids worker having unused Channel open to Pacemaker around.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kishorvpatil/incubator-storm storm1503

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1048.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1048
    
----
commit 01116450cfe981fdd37830d7ef2821ea3c0bf99a
Author: Kishor Patil <kp...@yahoo-inc.com>
Date:   2016-01-22T16:27:46Z

    Pacemaker client must try to reconnect on netty connecton failure

commit b0e696062ec690dc7e279349ce4d0015cd96c08d
Author: Kishor Patil <kp...@yahoo-inc.com>
Date:   2016-01-26T17:49:11Z

    Worker should retry later instead of dying on failure to send heartbeats to ZK/Pacemaker

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/1048#issuecomment-175186654
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1048


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/1048#issuecomment-175144958
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:

    https://github.com/apache/storm/pull/1048#issuecomment-175667437
  
    This needs to go on 1.x-branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-1503] Worker should not crash on failur...

Posted by redsanket <gi...@git.apache.org>.
Github user redsanket commented on the pull request:

    https://github.com/apache/storm/pull/1048#issuecomment-175175561
  
    +1 NB


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---