You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by mb...@apache.org on 2007/01/10 23:41:49 UTC
svn commit: r495016 - in
/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath:
ri/EvalContext.java util/ReverseComparator.java
Author: mbenson
Date: Wed Jan 10 14:41:48 2007
New Revision: 495016
URL: http://svn.apache.org/viewvc?view=rev&rev=495016
Log:
extract ReverseComparator to its own class
Added:
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java (with props)
Modified:
jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java
Modified: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java?view=diff&rev=495016&r1=495015&r2=495016
==============================================================================
--- jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java (original)
+++ jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/ri/EvalContext.java Wed Jan 10 14:41:48 2007
@@ -32,6 +32,7 @@
import org.apache.commons.jxpath.Pointer;
import org.apache.commons.jxpath.ri.axes.RootContext;
import org.apache.commons.jxpath.ri.model.NodePointer;
+import org.apache.commons.jxpath.util.ReverseComparator;
/**
* An XPath evaluation context.
@@ -52,14 +53,6 @@
private boolean hasPerformedIteratorStep = false;
private Iterator pointerIterator;
- // Sorts in the reverse order to the one defined by the Comparable
- // interface.
- private static final Comparator REVERSE_COMPARATOR = new Comparator() {
- public int compare(Object o1, Object o2) {
- return ((Comparable) o2).compareTo(o1);
- }
- };
-
public EvalContext(EvalContext parentContext) {
this.parentContext = parentContext;
}
@@ -196,7 +189,7 @@
Collections.sort(list);
}
else {
- Collections.sort(list, REVERSE_COMPARATOR);
+ Collections.sort(list, ReverseComparator.INSTANCE);
}
pointerIterator = list.iterator();
return true;
Added: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java?view=auto&rev=495016
==============================================================================
--- jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java (added)
+++ jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java Wed Jan 10 14:41:48 2007
@@ -0,0 +1,27 @@
+package org.apache.commons.jxpath.util;
+
+import java.util.Comparator;
+
+/**
+ * Reverse comparator.
+ *
+ * @author Dmitri Plotnikov
+ * @version $Revision:$ $Date:$
+ */
+public class ReverseComparator implements Comparator {
+ /**
+ * Singleton reverse comparator instance.
+ */
+ public static final Comparator INSTANCE = new ReverseComparator();
+
+ private ReverseComparator() {
+ }
+
+ /**
+ * {@inheritDoc}
+ */
+ public int compare(Object o1, Object o2) {
+ return ((Comparable) o2).compareTo(o1);
+ }
+
+}
Propchange: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
------------------------------------------------------------------------------
svn:eol-style = native
Propchange: jakarta/commons/proper/jxpath/trunk/src/java/org/apache/commons/jxpath/util/ReverseComparator.java
------------------------------------------------------------------------------
svn:executable = *
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org